Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2879633004: Read WebUSB landing page even if allowed origin read fails (Closed)

Created:
3 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Read WebUSB landing page even if allowed origin read fails Now that support for the GET_ALLOWED_ORIGINS request is optional WebUSB devices may only support the GET_URL request used for reading the landing page from the device. This patch fixes the descriptor reading logic so that this is supported. (Note, the logic to send the GET_ALLOWED_ORIGINS request will be removed entirely as part of issue 711443.) BUG=721546 Review-Url: https://codereview.chromium.org/2876463008 Cr-Original-Commit-Position: refs/heads/master@{#471141} Review-Url: https://codereview.chromium.org/2879633004 . Cr-Commit-Position: refs/branch-heads/3071@{#529} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/f00121a64ad04ba8f63eeb958c834d59c5700217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M device/usb/webusb_descriptors.cc View 3 chunks +25 lines, -26 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Reilly Grant (use Gerrit)
3 years, 7 months ago (2017-05-12 18:05:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f00121a64ad04ba8f63eeb958c834d59c5700217.

Powered by Google App Engine
This is Rietveld 408576698