Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2879613002: Revert of SimpleCache: Add a test that covers recovery from missing index. (Closed)

Created:
3 years, 7 months ago by Maks Orlovich
Modified:
3 years, 7 months ago
Reviewers:
whywhat, jkarlin
CC:
cbentzel+watch_chromium.org, chromium-reviews, gavinp+disk_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of SimpleCache: Add a test that covers recovery from missing index. (patchset #2 id:20001 of https://codereview.chromium.org/2878523002/ ) Reason for revert: Seem to break (or maybe just flake?) on "Android Cronet KitKat Builder". Need to figure out how to test it myself like that, I guess. Original issue's description: > SimpleCache: Add a test that covers recovery from missing index. > > (As I can't seem to find a preexisting one) > > BUG= > > Review-Url: https://codereview.chromium.org/2878523002 > Cr-Commit-Position: refs/heads/master@{#470947} > Committed: https://chromium.googlesource.com/chromium/src/+/31a646c7268cb0957b681ede8332da9bdc513bd2 TBR=jkarlin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2879613002 Cr-Commit-Position: refs/heads/master@{#470983} Committed: https://chromium.googlesource.com/chromium/src/+/6054fad43db3d76dfd926601c3be4e5d284d6d70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M net/disk_cache/backend_unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Maks Orlovich
Created Revert of SimpleCache: Add a test that covers recovery from missing index.
3 years, 7 months ago (2017-05-11 15:29:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879613002/1
3 years, 7 months ago (2017-05-11 15:29:46 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-11 15:29:48 UTC) #5
whywhat
lgtm
3 years, 7 months ago (2017-05-11 17:06:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879613002/1
3 years, 7 months ago (2017-05-11 17:07:54 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 17:08:40 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6054fad43db3d76dfd926601c3be...

Powered by Google App Engine
This is Rietveld 408576698