Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2879593004: Reorganize equivalence test helpers (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+945 lines, -1753 lines) Patch
A tests/compiler/dart2js/equivalence/check_functions.dart View 1 chunk +612 lines, -0 lines 0 comments Download
A + tests/compiler/dart2js/equivalence/check_helpers.dart View 3 chunks +4 lines, -359 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 3 chunks +7 lines, -220 lines 1 comment Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 4 chunks +3 lines, -44 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +2 lines, -43 lines 0 comments Download
A tests/compiler/dart2js/kernel/test_helpers.dart View 1 chunk +306 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/impact_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/library_test.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/serialization/members_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/model_test_helper.dart View 4 chunks +2 lines, -291 lines 0 comments Download
M tests/compiler/dart2js/serialization/native_data_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/reserialization_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/resolved_ast_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/compiler/dart2js/serialization/test_helper.dart View 2 chunks +0 lines, -783 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-12 09:09:21 UTC) #2
Siggi Cherem (dart-lang)
lgtm - I assume this is not new code and just code motion, but if ...
3 years, 7 months ago (2017-05-12 16:45:37 UTC) #3
Johnni Winther
https://codereview.chromium.org/2879593004/diff/1/tests/compiler/dart2js/kernel/closed_world2_test.dart File tests/compiler/dart2js/kernel/closed_world2_test.dart (left): https://codereview.chromium.org/2879593004/diff/1/tests/compiler/dart2js/kernel/closed_world2_test.dart#oldcode184 tests/compiler/dart2js/kernel/closed_world2_test.dart:184: void checkNativeClasses( These were changed to used [TestStrategy] instead ...
3 years, 7 months ago (2017-05-15 07:43:03 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-15 07:47:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2c2c32c57d452b71afbe26eeb4937e320c5fef6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698