Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Unified Diff: tests/compiler/dart2js/kernel/closed_world_test.dart

Issue 2879593004: Reorganize equivalence test helpers (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/kernel/closed_world_test.dart
diff --git a/tests/compiler/dart2js/kernel/closed_world_test.dart b/tests/compiler/dart2js/kernel/closed_world_test.dart
index a675fc42261fab5b9de39bf4852346a9b86fa647..3f2cb193996d34bd99e548825f03b3f83e3fa91c 100644
--- a/tests/compiler/dart2js/kernel/closed_world_test.dart
+++ b/tests/compiler/dart2js/kernel/closed_world_test.dart
@@ -32,6 +32,8 @@ import 'impact_test.dart';
import '../memory_compiler.dart';
import '../serialization/helper.dart';
import '../serialization/model_test_helper.dart';
+import '../equivalence/check_functions.dart';
+import 'test_helpers.dart';
const SOURCE = const {
'main.dart': '''
@@ -107,7 +109,7 @@ main(List<String> args) {
backend.nativeDataBuilder,
interceptorDataBuilder,
const OpenWorldStrategy()),
- new KernelWorkItemBuilder(compiler),
+ new KernelTestWorkItemBuilder(compiler),
'enqueuer from kernel');
ClosedWorld closedWorld = computeClosedWorld(
compiler.reporter, enqueuer, compiler.elementEnvironment);
@@ -123,23 +125,6 @@ main(List<String> args) {
});
}
-bool elementFilter(Entity element) {
- if (element is ConstructorElement && element.isRedirectingFactory) {
- // Redirecting factory constructors are skipped in kernel.
- return false;
- }
- if (element is ClassElement) {
- for (ConstructorElement constructor in element.constructors) {
- if (!constructor.isRedirectingFactory) {
- return true;
- }
- }
- // The class cannot itself be instantiated.
- return false;
- }
- return true;
-}
-
List createResolutionEnqueuerListener(Compiler compiler) {
JavaScriptBackend backend = compiler.backend;
BackendUsageBuilder backendUsageBuilder =
@@ -178,29 +163,3 @@ ClosedWorld computeClosedWorld(DiagnosticReporter reporter,
});
return enqueuer.worldBuilder.closeWorld();
}
-
-class KernelWorkItemBuilder implements WorkItemBuilder {
- final Compiler _compiler;
-
- KernelWorkItemBuilder(this._compiler);
-
- @override
- WorkItem createWorkItem(MemberEntity entity) {
- return new KernelWorkItem(
- _compiler, _compiler.backend.impactTransformer, entity);
- }
-}
-
-class KernelWorkItem implements ResolutionWorkItem {
- final Compiler _compiler;
- final ImpactTransformer _impactTransformer;
- final MemberElement element;
-
- KernelWorkItem(this._compiler, this._impactTransformer, this.element);
-
- @override
- WorldImpact run() {
- ResolutionImpact resolutionImpact = build(_compiler, element.resolvedAst);
- return _impactTransformer.transformResolutionImpact(resolutionImpact);
- }
-}

Powered by Google App Engine
This is Rietveld 408576698