Custom Tabs: disable all speculation if third party cookies are blocked.

Custom Tabs: disable all speculation if third party cookies are blocked.

Disable background tabs if third party cookies are blocked. See the bug for context.

This is already handled for prerender in the prerender_manager; this change
prevents a prerender from being created which is a minor efficiency improvement.

BUG=589374, 710720
Review-Url: https://codereview.chromium.org/2879583002
Cr-Commit-Position: refs/heads/master@{#471362}
Committed: https://chromium.googlesource.com/chromium/src/+/11109a9dd4f3750bdf0fc987b0eabe6de07e4f25

[mattcary, 2017-05-11 13:24:52]

mattcary@chromium.org changed reviewers:
+ lizeb@chromium.org, pasko@chromium.org

[mattcary, 2017-05-11 13:24:52]

Egor, Benoit: related to our UMA exploration this afternoon. Seems to be the
correct thing to do, WDYT?

[Benoit L, 2017-05-11 13:33:49]

On 2017/05/11 13:24:52, mattcary wrote:
> Egor, Benoit: related to our UMA exploration this afternoon. Seems to be the
> correct thing to do, WDYT?

lgtm, thanks!

[pasko, 2017-05-11 14:42:17]

lgtm

https://codereview.chromium.org/2879583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2879583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:958:
if (prefs.isBlockThirdPartyCookiesEnabled()) return false;
this way we will stop knowing how many prerenders are blocked because of the
third party cookies setting. For prerender it is not a problem, but it reminds
me that counts for these failure modes may become handy some day for background
tab and other customtabs speculative actions. Do we want this or it can wait?

[mattcary, 2017-05-12 13:42:50]

Also added some bonus tests. PTAL in case I did something silly.

https://codereview.chromium.org/2879583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
(right):

https://codereview.chromium.org/2879583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java:958:
if (prefs.isBlockThirdPartyCookiesEnabled()) return false;
On 2017/05/11 14:42:16, pasko wrote:
> this way we will stop knowing how many prerenders are blocked because of the
> third party cookies setting. For prerender it is not a problem, but it reminds
> me that counts for these failure modes may become handy some day for
background
> tab and other customtabs speculative actions. Do we want this or it can wait?

Yeah, I kind of wondered that. I also noticed that we don't actually histogram
background tab usage at all. That should probably be changed... it looks like
emitting to histograms is easy in CustomTabsConnection. I'll make another CL for
that.

[pasko, 2017-05-12 14:52:12]

still lgtm

[mattcary, 2017-05-12 14:56:03]

The CQ bit was checked by mattcary@chromium.org

[mattcary, 2017-05-12 14:56:03]

The patchset sent to the CQ was uploaded after l-g-t-m from lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/2879583002/#ps20001
(title: "add test")

[commit-bot: I haz the power, 2017-05-12 14:56:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mattcary, 2017-05-12 15:56:40]

Description was changed from

==========
Custom Tabs: disable all speculation if third party cookies are blocked.

Disable background tabs if third party cookies are blocked. See the bug for
context.

This is already handled for prerender in the prerender_manager; this change
prevents a prerender from being created which is a minor efficiency improvement.

BUG=589374
==========

to

==========
Custom Tabs: disable all speculation if third party cookies are blocked.

Disable background tabs if third party cookies are blocked. See the bug for
context.

This is already handled for prerender in the prerender_manager; this change
prevents a prerender from being created which is a minor efficiency improvement.

BUG=589374,710720
==========

[commit-bot: I haz the power, 2017-05-12 15:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 15:57:35]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mattcary, 2017-05-12 15:59:49]

The CQ bit was checked by mattcary@chromium.org

[mattcary, 2017-05-12 15:59:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pasko@chromium.org,
lizeb@chromium.org
Link to the patchset: https://codereview.chromium.org/2879583002/#ps40001
(title: "Removed dead code from test copy-paste.")

[commit-bot: I haz the power, 2017-05-12 16:00:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 17:54:48]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494604789671760,
"parent_rev": "8f9139e413e30b6e7a79a48c852cce057ac8bff9", "commit_rev":
"11109a9dd4f3750bdf0fc987b0eabe6de07e4f25"}

[commit-bot: I haz the power, 2017-05-12 17:54:59]

Description was changed from

==========
Custom Tabs: disable all speculation if third party cookies are blocked.

Disable background tabs if third party cookies are blocked. See the bug for
context.

This is already handled for prerender in the prerender_manager; this change
prevents a prerender from being created which is a minor efficiency improvement.

BUG=589374,710720
==========

to

==========
Custom Tabs: disable all speculation if third party cookies are blocked.

Disable background tabs if third party cookies are blocked. See the bug for
context.

This is already handled for prerender in the prerender_manager; this change
prevents a prerender from being created which is a minor efficiency improvement.

BUG=589374,710720

Review-Url: https://codereview.chromium.org/2879583002
Cr-Commit-Position: refs/heads/master@{#471362}
Committed:
https://chromium.googlesource.com/chromium/src/+/11109a9dd4f3750bdf0fc987b0ea...
==========

[commit-bot: I haz the power, 2017-05-12 17:54:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/11109a9dd4f3750bdf0fc987b0ea...