Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/BUILD.gn

Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields (Closed)
Patch Set: shend@'s suggestions Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('j') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/BUILD.gn
diff --git a/third_party/WebKit/Source/core/BUILD.gn b/third_party/WebKit/Source/core/BUILD.gn
index 4804605f9a966c1b850acfc1acd7d3aecde58455..79c76954ec6c3bb2d3c2cb983dc1730f008f8752 100644
--- a/third_party/WebKit/Source/core/BUILD.gn
+++ b/third_party/WebKit/Source/core/BUILD.gn
@@ -410,7 +410,10 @@ action("generated_testing_idls_internal_runtime_flags") {
css_properties("make_core_generated_computed_style_base") {
script = "../build/scripts/make_computed_style_base.py"
- in_files = [ "css/ComputedStyleExtraFields.json5" ]
+ in_files = [
+ "css/ComputedStyleExtraFields.json5",
+ "css/ComputedStyleDiffFunctions.json5",
+ ]
other_inputs = [
"../build/scripts/templates/fields/field.tmpl",
"../build/scripts/templates/fields/group.tmpl",
« third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl ('K') | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('j') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('J')

Powered by Google App Engine
This is Rietveld 408576698