third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl - Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

Issue 2879563002: Refactor code generation to allow us to diff generic expressions and not just fields (Closed)

Patch Set: shend@'s suggestions Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('K') | « third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('j') | third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

index 2757340d87409c4ea039604422c543432e46ed6c..b5d3bcbd3da0de97e43119869723a484f1516dae 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl

@@ -87,8 +87,7 @@ class CORE_EXPORT ComputedStyleBase {

void CopyNonInheritedFromCached(const ComputedStyleBase& other);

bool DiffNeedsFullLayoutAndPaintInvalidation(

const ComputedStyleBase& other) const;

- bool ScrollAnchorDisablingPropertyChanged(const ComputedStyleBase& other,

- const StyleDifference&) const;

+ bool ScrollAnchorDisablingPropertyChanged(const ComputedStyleBase& other) const;

alancutter (OOO until 2018) 2017/05/12 04:04:51 Can we generate these function names instead?

nainar 2017/05/12 05:05:36 Made this CL: https://codereview.chromium.org/2875

// Copies the values of any independent inherited properties from the parent

// style that are marked as inherited by this style.