PDF Plugin: Add dummy JS compilation target.

PDF Plugin: Add dummy JS compilation target.

- Uncomment line at third_party/closure_compiler/compiled_resources2.gyp:36
- Execute ./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2879543002
Cr-Commit-Position: refs/heads/master@{#472309}
Committed: https://chromium.googlesource.com/chromium/src/+/367dcbb346040d38334453592c0f61d827a00cae

[dpapad, 2017-05-11 01:16:27]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

BUG=721073
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-11 01:16:53]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

./third_party/closure_compiler/run_compiler main

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-11 01:16:53]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

./third_party/closure_compiler/run_compiler main

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-11 01:18:15]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-05-11 01:20:17]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-05-11 01:21:03]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-05-11 01:21:15]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[commit-bot: I haz the power, 2017-05-11 01:22:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2017-05-11 01:33:11]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-05-11 01:33:12]

https://codereview.chromium.org/2879543002/diff/40001/third_party/closure_com...
File third_party/closure_compiler/compiled_resources2.gyp (right):

https://codereview.chromium.org/2879543002/diff/40001/third_party/closure_com...
third_party/closure_compiler/compiled_resources2.gyp:36:
'<(DEPTH)/chrome/browser/resources/print_preview/compiled_resources2.gyp:*',
BTW, did you want to keep these in alphabetical order?

[commit-bot: I haz the power, 2017-05-11 01:36:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 01:36:50]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-05-11 01:37:56]

Patchset #4 (id:60001) has been deleted

[dpapad, 2017-05-11 01:39:33]

https://codereview.chromium.org/2879543002/diff/40001/third_party/closure_com...
File third_party/closure_compiler/compiled_resources2.gyp (right):

https://codereview.chromium.org/2879543002/diff/40001/third_party/closure_com...
third_party/closure_compiler/compiled_resources2.gyp:36:
'<(DEPTH)/chrome/browser/resources/print_preview/compiled_resources2.gyp:*',
On 2017/05/11 at 01:33:12, Lei Zhang (OOO) wrote:
> BTW, did you want to keep these in alphabetical order?

Done.

[Lei Zhang, 2017-05-11 01:47:28]

rs lgtm for chrome/OWNERS

[Dan Beam, 2017-05-16 03:08:40]

https://codereview.chromium.org/2879543002/diff/80001/third_party/closure_com...
File third_party/closure_compiler/compiled_resources2.gyp (right):

https://codereview.chromium.org/2879543002/diff/80001/third_party/closure_com...
third_party/closure_compiler/compiled_resources2.gyp:36:
'<(DEPTH)/chrome/browser/resources/pdf/compiled_resources2.gyp:*',
i don't think you actually want this line uncommented

[dpapad, 2017-05-16 17:17:12]

https://codereview.chromium.org/2879543002/diff/80001/third_party/closure_com...
File third_party/closure_compiler/compiled_resources2.gyp (right):

https://codereview.chromium.org/2879543002/diff/80001/third_party/closure_com...
third_party/closure_compiler/compiled_resources2.gyp:36:
'<(DEPTH)/chrome/browser/resources/pdf/compiled_resources2.gyp:*',
On 2017/05/16 at 03:08:40, Dan Beam wrote:
> i don't think you actually want this line uncommented

Done.

[Dan Beam, 2017-05-16 23:56:33]

is there a reason to commit this now without anything actually being built?  why
not just commit when we're actually compiling by expressing the dependencies
correctly?

there's literally 1000+ examples of this kind of target in chrome already...
(find -type f -name compiled_resources2.gyp)

[dpapad, 2017-05-17 00:00:19]

On 2017/05/16 at 23:56:33, dbeam wrote:
> is there a reason to commit this now without anything actually being built? 
why not just commit when we're actually compiling by expressing the dependencies
correctly?
> 
> there's literally 1000+ examples of this kind of target in chrome already...
(find -type f -name compiled_resources2.gyp)

My understanding is that there will be quite a few errors (in the order of
hundreds), and it is more convenient to keep fixing those in a series of CLs
while keeping the closure_compiler/compiled_resources2.gyp entry for PDF plugin
commented out.

Benefit 1: Allows parallelization in case of multiple contributors.
Contributor A, uncomments the line locally and fixes some errors.
Contributor B, uncomments the line locally and fixes other errors.

Benefit2: Reviewers will review smaller CLs, compared to a single big bang CL
that fixes all the errors at once. The CL that fixes the last errors would
uncomment that line.

[Dan Beam, 2017-05-17 00:44:57]

detriment 1: extra code in chrome that might never live
detriment 2: we generally don't check in commented code

but i guess it could be easier to uncomment that add the line every time.  fwiw:
you can also just add more specific files (i.e. you can add subsections to the
top-level file used by the bots and run_compiler)

lgtm do whatever you want ;)

[dpapad, 2017-05-17 01:03:57]

On 2017/05/17 at 00:44:57, dbeam wrote:
> detriment 1: extra code in chrome that might never live
> detriment 2: we generally don't check in commented code
> 
> but i guess it could be easier to uncomment that add the line every time. 
fwiw: you can also just add more specific files (i.e. you can add subsections to
the top-level file used by the bots and run_compiler)
> 
> lgtm do whatever you want ;)

Thanks. I am hoping that it is possible to fully type check the PDF plugin code
with reasonable effort, such that this will not end up being dead code. If
anything, the TODO with my name next to it is a motivation to either finish
this, or remove this code if we determine that compiling PDF Plugin is
infeasible.

[dpapad, 2017-05-17 01:05:37]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

./third_party/closure_compiler/run_compiler main

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-17 01:06:37]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

- Uncomment line at third_party/closure_compiler/compiled_resources2.gyp:36
- Execute ./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-05-17 01:28:19]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-05-17 01:28:20]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2879543002/#ps100001
(title: "Comment.")

[commit-bot: I haz the power, 2017-05-17 01:29:58]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 01:35:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 01:35:57]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dpapad, 2017-05-17 01:36:54]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2017-05-17 01:36:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2879543002/#ps120001
(title: "Resolve conflicts.")

[commit-bot: I haz the power, 2017-05-17 01:38:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:42:59]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494985014740230,
"parent_rev": "0b0a0385c305c9dffc2cca15e3f58917ec245299", "commit_rev":
"367dcbb346040d38334453592c0f61d827a00cae"}

[commit-bot: I haz the power, 2017-05-17 03:43:14]

Description was changed from

==========
PDF Plugin: Add dummy JS compilation target.

- Uncomment line at third_party/closure_compiler/compiled_resources2.gyp:36
- Execute ./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
PDF Plugin: Add dummy JS compilation target.

- Uncomment line at third_party/closure_compiler/compiled_resources2.gyp:36
- Execute ./third_party/closure_compiler/run_compiler main

The dummy compilation target will facilitate the work needed to
fully type check the PDF Plugin's JS codebase.

BUG=721073
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2879543002
Cr-Commit-Position: refs/heads/master@{#472309}
Committed:
https://chromium.googlesource.com/chromium/src/+/367dcbb346040d38334453592c0f...
==========

[commit-bot: I haz the power, 2017-05-17 03:43:15]

Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/367dcbb346040d38334453592c0f...