Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2879493005: [Merge to M59] Linux Aura: Use incognito profile to theme incognito browser windows (Closed)

Created:
3 years, 7 months ago by Tom Anderson
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge to M59] Linux Aura: Use incognito profile to theme incognito browser windows > This CL sets the theme profile of browser windows to the same as the > actual profile. The theme profile for children windows will continue > using the original (ie. non-incognito) profile. > > This fixes an issue where incognito windows using the classic Aura > theme would use NativeThemeAura instead of NativeThemeDarkAura. > > BUG=715710 > R=sky@chromium.org > CC=estade@chromium.org > > Review-Url: https://codereview.chromium.org/2862113002 > Cr-Commit-Position: refs/heads/master@{#470478} > BUG=715710 TBR=sky@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2879493005 Cr-Commit-Position: refs/branch-heads/3071@{#516} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/922ab8befea81359ed483317f012072d2a3253d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -80 lines) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chrome_browser_main_extra_parts_views_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/native_widget_factory.cc View 2 chunks +20 lines, -20 lines 0 comments Download
D chrome/browser/ui/views/theme_profile_key.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/ui/views/theme_profile_key.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879493005/1
3 years, 7 months ago (2017-05-11 18:36:29 UTC) #2
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:38:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/922ab8befea81359ed483317f012...

Powered by Google App Engine
This is Rietveld 408576698