third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl - Issue 2879493003: Check if value changed when setting nested fields in ComputedStyleBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

Issue 2879493003: Check if value changed when setting nested fields in ComputedStyleBase. (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/base.tmpl ('k') | third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

index 839d395a38a8ea022d6923cd95812b868721f5da..770282926e98a7636b98f71495962c87266505d7 100644

--- a/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/fields/external.tmpl

@@ -1,12 +1,17 @@

{% import 'fields/base.tmpl' as base %}

-{% from 'fields/field.tmpl' import setter_expression %}

+{% from 'fields/field.tmpl' import getter_expression, setter_expression %}

{% macro decl_public_methods(field) %}

void {{field.setter_method_name}}({{field.type_name}}&& v) {

- {{setter_expression(field)}} = std::move(v);

+{% if field.group_member_name %}

+ if (!({{getter_expression(field)}} == v))

+ {{setter_expression(field)}} = std::move(v);

+{% else %}

+ {{field.name}} = std::move({{value}});

alancutter (OOO until 2018) 2017/05/11 05:56:38 Should this be referencing v instead of {{value}}?

shend 2017/05/11 06:03:00 Oops, good catch.

+{% endif %}

}

{% endmacro %}