Chromium Code Reviews Chromium Code Reviews
Issue 2879493003:
Check if value changed when setting nested fields in ComputedStyleBase. (Closed)
| OLD | NEW |
|---|---|
| 1 {% import 'fields/base.tmpl' as base %} | 1 {% import 'fields/base.tmpl' as base %} |
| 2 {% from 'fields/field.tmpl' import setter_expression %} | 2 {% from 'fields/field.tmpl' import getter_expression, setter_expression %} |
| 3 | 3 |
| 4 {% macro decl_public_methods(field) %} | 4 {% macro decl_public_methods(field) %} |
| 5 {{base.decl_initial_method(field)}} | 5 {{base.decl_initial_method(field)}} |
| 6 {{base.decl_getter_method(field)}} | 6 {{base.decl_getter_method(field)}} |
| 7 {{base.decl_setter_method(field)}} | 7 {{base.decl_setter_method(field)}} |
| 8 void {{field.setter_method_name}}({{field.type_name}}&& v) { | 8 void {{field.setter_method_name}}({{field.type_name}}&& v) { |
| 9 {{setter_expression(field)}} = std::move(v); | 9 {% if field.group_member_name %} |
| 10 if (!({{getter_expression(field)}} == v)) | |
| 11 {{setter_expression(field)}} = std::move(v); | |
| 12 {% else %} | |
| 13 {{field.name}} = std::move({{value}}); | |
|
alancutter (OOO until 2018)
2017/05/11 05:56:38
Should this be referencing v instead of {{value}}?
shend
2017/05/11 06:03:00
Oops, good catch.
| |
| 14 {% endif %} | |
| 10 } | 15 } |
| 11 {{base.decl_resetter_method(field)}} | 16 {{base.decl_resetter_method(field)}} |
| 12 {% endmacro %} | 17 {% endmacro %} |
| 13 | 18 |
| 14 {% macro decl_protected_methods(field) -%} | 19 {% macro decl_protected_methods(field) -%} |
| 15 {{base.decl_mutable_method(field)}} | 20 {{base.decl_mutable_method(field)}} |
| 16 {%- endmacro %} | 21 {%- endmacro %} |
| OLD | NEW |
