Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 2879433002: [Payment Request] PaymentsSelectorEditItem (Closed)

Created:
3 years, 7 months ago by Moe
Modified:
3 years, 7 months ago
Reviewers:
macourteau
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, pkl (ping after 24h if needed), mathp+autofillwatch_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, Justin Donnelly
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] PaymentsSelectorEditItem Features an item similar to AutofillEditItem to be used in the payments edit form for fields that have noneditable values (e.g., selector fields). BUG=602666 TBR=jdonnelly@ Review-Url: https://codereview.chromium.org/2879433002 Cr-Commit-Position: refs/heads/master@{#470977} Committed: https://chromium.googlesource.com/chromium/src/+/830ee43a3674559b0666d2041fe2b4bf6cee0b35

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -0 lines) Patch
M ios/chrome/browser/ui/autofill/autofill_ui_type.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/payments/cells/BUILD.gn View 3 chunks +5 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.h View 1 chunk +49 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/cells/payments_selector_edit_item.mm View 1 chunk +79 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/payments/cells/payments_selector_edit_item_unittests.mm View 1 1 chunk +44 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (13 generated)
Moe
Hi MAC, Please take a look.
3 years, 7 months ago (2017-05-10 19:30:35 UTC) #4
macourteau
lgtm w/ a couple questions https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right): https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm#newcode83 ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case AutofillUITypeCreditCardBillingAddress: Why does ...
3 years, 7 months ago (2017-05-10 19:51:17 UTC) #5
Moe
Thanks. https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right): https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm#newcode83 ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case AutofillUITypeCreditCardBillingAddress: On 2017/05/10 19:51:16, macourteau wrote: > ...
3 years, 7 months ago (2017-05-11 14:17:19 UTC) #9
macourteau
lgtm https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right): https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm#newcode83 ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case AutofillUITypeCreditCardBillingAddress: On 2017/05/11 14:17:18, Moe wrote: > ...
3 years, 7 months ago (2017-05-11 14:25:07 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879433002/20001
3 years, 7 months ago (2017-05-11 16:33:21 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 16:40:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/830ee43a3674559b0666d2041fe2...

Powered by Google App Engine
This is Rietveld 408576698