[Payment Request] PaymentsSelectorEditItem

[Payment Request] PaymentsSelectorEditItem

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666
TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2879433002
Cr-Commit-Position: refs/heads/master@{#470977}
Committed: https://chromium.googlesource.com/chromium/src/+/830ee43a3674559b0666d2041fe2b4bf6cee0b35

[Moe, 2017-05-10 19:19:29]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 19:21:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-10 19:30:34]

mahmadi@chromium.org changed reviewers:
+ macourteau@chromium.org

[Moe, 2017-05-10 19:30:35]

Hi MAC, Please take a look.

[macourteau, 2017-05-10 19:51:17]

lgtm w/ a couple questions

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right):

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case
AutofillUITypeCreditCardBillingAddress:
Why does this fallthrough to default: ? Is it intended to be in another CL? If
not, shouldn't it return something instead of hitting NOTREACHED()?

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/payme...
File
ios/chrome/browser/ui/payments/cells/payments_selector_edit_item_unittests.mm
(right):

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/cells/payments_selector_edit_item_unittests.mm:35:
EXPECT_NSEQ(name, detailCell.textLabel.text);
Maybe add a check that required fields have a "*" appended?

[commit-bot: I haz the power, 2017-05-10 21:22:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 21:22:37]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-05-11 14:16:50]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2017-05-11 14:17:19]

Thanks.

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right):

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case
AutofillUITypeCreditCardBillingAddress:
On 2017/05/10 19:51:16, macourteau wrote:
> Why does this fallthrough to default: ? Is it intended to be in another CL? If
> not, shouldn't it return something instead of hitting NOTREACHED()?

This is intended. AutofillUITypeCreditCardBillingAddress doesn't actually map to
any autofill data type. We're only using the UI type to identify the form field
for the billing address.

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/payme...
File
ios/chrome/browser/ui/payments/cells/payments_selector_edit_item_unittests.mm
(right):

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/cells/payments_selector_edit_item_unittests.mm:35:
EXPECT_NSEQ(name, detailCell.textLabel.text);
On 2017/05/10 19:51:16, macourteau wrote:
> Maybe add a check that required fields have a "*" appended?

Done.

[commit-bot: I haz the power, 2017-05-11 14:17:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2017-05-11 14:19:02]

Description was changed from

==========
[Payment Request] PaymentsSelectorEditItem

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666
==========

to

==========
[Payment Request] PaymentsSelectorEditItem

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666

TBR=jdonnelly@
==========

[macourteau, 2017-05-11 14:25:07]

lgtm

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
File ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm (right):

https://codereview.chromium.org/2879433002/diff/1/ios/chrome/browser/ui/autof...
ios/chrome/browser/ui/autofill/autofill_ui_type_util.mm:83: case
AutofillUITypeCreditCardBillingAddress:
On 2017/05/11 14:17:18, Moe wrote:
> On 2017/05/10 19:51:16, macourteau wrote:
> > Why does this fallthrough to default: ? Is it intended to be in another CL?
If
> > not, shouldn't it return something instead of hitting NOTREACHED()?
> 
> This is intended. AutofillUITypeCreditCardBillingAddress doesn't actually map
to
> any autofill data type. We're only using the UI type to identify the form
field
> for the billing address.

Acknowledged.

[commit-bot: I haz the power, 2017-05-11 16:29:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:29:06]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-05-11 16:32:39]

The CQ bit was checked by mahmadi@chromium.org

[commit-bot: I haz the power, 2017-05-11 16:33:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 16:40:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494520359148040,
"parent_rev": "1ddae8b5060f149a7819414f416713840c640ba7", "commit_rev":
"830ee43a3674559b0666d2041fe2b4bf6cee0b35"}

[commit-bot: I haz the power, 2017-05-11 16:40:58]

Description was changed from

==========
[Payment Request] PaymentsSelectorEditItem

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666

TBR=jdonnelly@
==========

to

==========
[Payment Request] PaymentsSelectorEditItem

Features an item similar to AutofillEditItem to be used in the
payments edit form for fields that have noneditable values (e.g.,
selector fields).

BUG=602666

TBR=jdonnelly@

Review-Url: https://codereview.chromium.org/2879433002
Cr-Commit-Position: refs/heads/master@{#470977}
Committed:
https://chromium.googlesource.com/chromium/src/+/830ee43a3674559b0666d2041fe2...
==========

[commit-bot: I haz the power, 2017-05-11 16:40:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/830ee43a3674559b0666d2041fe2...