Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2879423002: [ObjC ARC] Converts ios/chrome/browser/web:test_support to ARC. (Closed)

Created:
3 years, 7 months ago by liaoyuke
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/web:test_support to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2879423002 Cr-Commit-Position: refs/heads/master@{#472545} Committed: https://chromium.googlesource.com/chromium/src/+/45371c8b1e01bac440bc20f29782ceec2580bbc7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web/chrome_web_test.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/web/fake_mailto_handler_helpers.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
liaoyuke
Hi Eugene, PTAL. Thank you very much!
3 years, 7 months ago (2017-05-17 15:28:02 UTC) #6
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-05-17 18:24:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879423002/1
3 years, 7 months ago (2017-05-17 18:28:44 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 20:16:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/45371c8b1e01bac440bc20f29782...

Powered by Google App Engine
This is Rietveld 408576698