dart2js + html: getBoundingClientRect() returns a ClientRect

dart2js + html: getBoundingClientRect() returns a ClientRect

Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com, terry@google.com

Committed: https://github.com/dart-lang/sdk/commit/9c3d439b1e63012af6158db320e6a2874e48d44b

[sra1, 2017-05-15 21:54:55]

sra@google.com changed reviewers:
+ terry@google.com

[terry, 2017-05-15 21:57:18]

lgtm

[Jacob, 2017-05-15 21:59:52]

jacobr@google.com changed reviewers:
+ jacobr@google.com

[Jacob, 2017-05-15 21:59:53]

lgtm

https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
File tools/dom/scripts/dartmetadata.py (right):

https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
tools/dom/scripts/dartmetadata.py:110: "@Creates('_ClientRect')",
I don't think the return value from getBoundingClientRect
can really be null.
https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect

[sra1, 2017-05-16 20:43:42]

https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
File tools/dom/scripts/dartmetadata.py (right):

https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
tools/dom/scripts/dartmetadata.py:110: "@Creates('_ClientRect')",
On 2017/05/15 21:59:53, Jacob wrote:
> I don't think the return value from getBoundingClientRect
> can really be null.
> https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect

I don't think it can be null, but I am going to play it safe.
For field accesses like .top, it does not make a difference in generated code
quality.

[Jacob, 2017-05-16 20:44:21]

On 2017/05/16 20:43:42, sra1 wrote:
>
https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
> File tools/dom/scripts/dartmetadata.py (right):
> 
>
https://codereview.chromium.org/2879403002/diff/1/tools/dom/scripts/dartmetad...
> tools/dom/scripts/dartmetadata.py:110: "@Creates('_ClientRect')",
> On 2017/05/15 21:59:53, Jacob wrote:
> > I don't think the return value from getBoundingClientRect
> > can really be null.
> >
https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect
> 
> I don't think it can be null, but I am going to play it safe.
> For field accesses like .top, it does not make a difference in generated code
> quality.

lgtm

[sra1, 2017-05-16 20:48:19]

Description was changed from

==========
dart2js + html: getBoundingClientRect() returns a ClientRect

Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
==========

to

==========
dart2js + html: getBoundingClientRect() returns a ClientRect

Gives better code since the general Rectangle requires getInterceptor
dispatch.

BUG= https://github.com/dart-lang/sdk/issues/29602
R=jacobr@google.com, terry@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9c3d439b1e63012af6158db320e6a2874e48d44b
==========

[sra1, 2017-05-16 20:48:20]

Committed patchset #2 (id:20001) manually as
9c3d439b1e63012af6158db320e6a2874e48d44b (presubmit successful).