tools/dom/scripts/dartmetadata.py - Issue 2879403002: dart2js + html: getBoundingClientRect() returns a ClientRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/scripts/dartmetadata.py

Issue 2879403002: dart2js + html: getBoundingClientRect() returns a ClientRect (Closed)

Patch Set: add TODO comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/scripts/dartmetadata.py

diff --git a/tools/dom/scripts/dartmetadata.py b/tools/dom/scripts/dartmetadata.py

index 7ec8331df2b54288efb4b619dbdb212c4d8801d2..25f00ce031c2944a404ccf11892bf741f945b115 100644

--- a/tools/dom/scripts/dartmetadata.py

+++ b/tools/dom/scripts/dartmetadata.py

@@ -106,6 +106,11 @@ _dart2js_annotations = monitored.Dict('dartmetadata._dart2js_annotations', {

"@Returns('NodeList')",

+ 'Element.getBoundingClientRect': [

+ "@Creates('_ClientRect')",

+ "@Returns('_ClientRect|Null')", # TODO(sra): Verify and remove Null.

+ ],

# Methods returning Window can return a local window, or a cross-frame

# window (=Object) that needs wrapping.

'Window': [

« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | no next file » | no next file with comments »