Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2879373002: Revert of mesa: Disable support for loading libtxc_dxtn.so if msan is enabled. (Closed)

Created:
3 years, 7 months ago by pcc1
Modified:
3 years, 7 months ago
Reviewers:
Nico, Stephen White
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mesa: Disable support for loading libtxc_dxtn.so if msan is enabled. (patchset #2 id:20001 of https://codereview.chromium.org/2876693003/ ) Reason for revert: Large number of perf regressions on mac. BUG=722473 Original issue's description: > mesa: Disable support for loading libtxc_dxtn.so if msan is enabled. > > The libtxc_dxtn.so library supports loading textures in S3TC > format. This change disables code in mesa that loads libtxc_dxtn.so > if msan is enabled, as the library will be loaded from a system > directory, which may cause spurious msan reports because msan expects > most libraries in the process to be compiled with msan. > > For some reason, msan only appears to break when compiling with -Os, > as revealed by a recent attempt [0] to enable -Os on Linux and Mac. > > [0] https://codereview.chromium.org/2864383003/ > > BUG=660216 > R=senorblanco@chromium.org,thakis@chromium.org > > Review-Url: https://codereview.chromium.org/2876693003 > Cr-Commit-Position: refs/heads/master@{#471045} > Committed: https://chromium.googlesource.com/chromium/src/+/97b99808511f8918d00add266a8555ba5e21813c TBR=senorblanco@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=660216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/mesa/BUILD.gn View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
pcc1
Created Revert of mesa: Disable support for loading libtxc_dxtn.so if msan is enabled.
3 years, 7 months ago (2017-05-15 19:56:10 UTC) #2
pcc1
3 years, 7 months ago (2017-05-15 19:56:55 UTC) #4
Oops, created a revert of the wrong CL, closing.

Powered by Google App Engine
This is Rietveld 408576698