Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2879273002: Make server use the common protocol classes (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
danrubel
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12894 lines, -19863 lines) Patch
M pkg/analysis_server/benchmark/integration/input_converter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_flutter.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_scenario.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 44 chunks +3805 lines, -3830 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/navigation/navigation_core.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences_core.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_core.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_core.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol.dart View 10 chunks +90 lines, -35 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 70 chunks +3266 lines, -8616 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_highlights2.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_outline.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_completion.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/notification_manager.dart View 11 chunks +34 lines, -68 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/request_converter.dart View 2 chunks +1 line, -18 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_converter.dart View 3 chunks +7 lines, -54 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/result_merger.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol/protocol_internal.dart View 2 chunks +6 lines, -142 lines 0 comments Download
M pkg/analysis_server/lib/src/protocol_server.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion_core.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/refactoring/refactoring_core.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/common_usage_sorter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/contribution_sorter.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/keyword_contributor.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_constructor_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/named_constructor_contributor.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/utilities.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/sort_members.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/source_buffer.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/status.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler2.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/get_errors_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/navigation_collector_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_errors_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_highlights_test2.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_navigation_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_occurrences_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_outline_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_overrides_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/analysis/reanalyze_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis_server_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/completion_test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/domain_analysis_test.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 3 chunks +4 lines, -13 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_util.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/edit/format_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/organize_directives_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/refactoring_test.dart View 4 chunks +16 lines, -19 lines 0 comments Download
M pkg/analysis_server/test/edit/sort_members_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/statement_completion_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/analysis_options_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/error_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_nonStandard_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_navigation_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/highlights_test2.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/lint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/navigation_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/occurrences_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/outline_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/package_root_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_list_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/analysis/update_content_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/integration/completion/get_suggestions_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/get_assists_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/get_fixes_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/organize_directives_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/edit/sort_members_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/search/get_type_hierarchy_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/integration_test_methods.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/integration_tests.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 2 chunks +1494 lines, -1494 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/plugin/protocol_dart_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/plugin/set_analysis_domain_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 4 chunks +3 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/search/abstract_search_domain.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/element_references_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/member_declarations_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/top_level_declarations_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/search/type_hierarchy_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/common_usage_sorter_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/imported_reference_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/keyword_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/label_contributor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_constructor_contributor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/named_constructor_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/override_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/type_member_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 2 chunks +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/organize_directives_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/sort_members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/util_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_refactoring.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/abstract_rename.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_getter_to_method_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/convert_method_to_getter_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/extract_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/inline_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/naming_conventions_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_constructor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_import_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_label_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_library_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_local_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/refactoring/rename_unit_member_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/plugin/notification_manager_test.dart View 18 chunks +67 lines, -81 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/protocol_test_utilities.dart View 10 chunks +84 lines, -101 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/request_converter_test.dart View 3 chunks +5 lines, -52 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/result_converter_test.dart View 4 chunks +25 lines, -231 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/result_merger_test.dart View 3 chunks +19 lines, -21 lines 0 comments Download
M pkg/analysis_server/test/stress/replay/replay.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/stress/utilities/server.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/test/timing/completion/completion_simple.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/api.dart View 2 chunks +4 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 4 chunks +31 lines, -12 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_inttest_methods.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_matchers.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/from_html.dart View 1 chunk +547 lines, -502 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/CompletionSuggestion.java View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/CompletionSuggestionKind.java View 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/Outline.java View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RefactoringMethodParameter.java View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/RefactoringProblemSeverity.java View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 2 chunks +3191 lines, -4336 lines 0 comments Download
M pkg/analysis_server/tool/spec/to_html.dart View 8 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
This is a ridiculously large number of files, and I apologize. Hopefully it won't take ...
3 years, 7 months ago (2017-05-15 16:08:55 UTC) #2
danrubel
LGTM
3 years, 7 months ago (2017-05-15 16:30:12 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-15 16:35:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb982f547620032f57d6111b1017ce0278a4a0ba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698