Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 2879273002: Make server use the common protocol classes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index aa1c1c06a4eed69df31390feb0f016bef7ac0e75..e015a40acacf0af45655680c0fbabda42a7974a8 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -2,8 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library domain.completion;
-
import 'dart:async';
import 'package:analysis_server/protocol/protocol.dart';
@@ -12,13 +10,13 @@ import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/constants.dart';
import 'package:analysis_server/src/domain_abstract.dart';
import 'package:analysis_server/src/plugin/plugin_manager.dart';
-import 'package:analysis_server/src/plugin/result_converter.dart';
import 'package:analysis_server/src/provisional/completion/completion_core.dart';
import 'package:analysis_server/src/services/completion/completion_core.dart';
import 'package:analysis_server/src/services/completion/completion_performance.dart';
import 'package:analyzer/src/dart/analysis/driver.dart';
import 'package:analyzer/src/generated/source.dart';
import 'package:analyzer_plugin/protocol/protocol.dart' as plugin;
+import 'package:analyzer_plugin/protocol/protocol_common.dart';
import 'package:analyzer_plugin/protocol/protocol_constants.dart' as plugin;
import 'package:analyzer_plugin/protocol/protocol_generated.dart' as plugin;
@@ -118,12 +116,10 @@ class CompletionDomainHandler extends AbstractRequestHandler {
if (pluginFutures != null) {
List<plugin.Response> responses = await waitForResponses(pluginFutures,
requestParameters: requestParams);
- ResultConverter converter = new ResultConverter();
for (plugin.Response response in responses) {
plugin.CompletionGetSuggestionsResult result =
new plugin.CompletionGetSuggestionsResult.fromResponse(response);
- suggestions
- .addAll(result.results.map(converter.convertCompletionSuggestion));
+ suggestions.addAll(result.results);
}
}
//

Powered by Google App Engine
This is Rietveld 408576698