Regsiter Ash prefs in mash

Regsiter Ash prefs in mash

In classic ash, Chrome will invoke registering Ash prefs to the
asctive user's pref service, but in mash, Ash (as a pref service
client) must do that itself before connecting to the pref service.

BUG=721751
Review-Url: https://codereview.chromium.org/2879243003
Cr-Commit-Position: refs/heads/master@{#472137}
Committed: https://chromium.googlesource.com/chromium/src/+/606424bd7f6b579fdc99e1d230911b68147ecb31

[afakhry, 2017-05-15 20:47:37]

afakhry@chromium.org changed reviewers:
+ sammc@chromium.org

[afakhry, 2017-05-15 20:47:38]

Please take a look. Thank you!

[Sam McNally, 2017-05-15 22:31:09]

lgtm

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc#newcode809
ash/shell.cc:809: make_scoped_refptr(new PrefRegistrySimple());
I think base::MakeShared might be the new preferred pattern:
auto pref_registry = base::MakeShared<PrefRegistrySimple>();

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc#newcode812
ash/shell.cc:812: shell_delegate_->GetShellConnector(), pref_registry,
std::move(pref_registry)

[afakhry, 2017-05-16 00:26:57]

afakhry@chromium.org changed reviewers:
+ jamescook@chromium.org

[afakhry, 2017-05-16 00:26:58]

+james for OWNERS.

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc#newcode809
ash/shell.cc:809: make_scoped_refptr(new PrefRegistrySimple());
On 2017/05/15 22:31:09, Sam McNally wrote:
> I think base::MakeShared might be the new preferred pattern:
> auto pref_registry = base::MakeShared<PrefRegistrySimple>();

Done.

https://codereview.chromium.org/2879243003/diff/1/ash/shell.cc#newcode812
ash/shell.cc:812: shell_delegate_->GetShellConnector(), pref_registry,
On 2017/05/15 22:31:09, Sam McNally wrote:
> std::move(pref_registry)

Done.

[James Cook, 2017-05-16 01:06:24]

LGTM. Thanks for fighting through all this ash prefs stuff - it'll make it
better for everyone who comes later.

[afakhry, 2017-05-16 16:16:43]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-05-16 16:16:44]

The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org
Link to the patchset: https://codereview.chromium.org/2879243003/#ps20001
(title: "sammc's comments")

[commit-bot: I haz the power, 2017-05-16 16:17:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 17:08:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494951403646260,
"parent_rev": "2b2e015645ab445cd24d352cb104eb45f396ecad", "commit_rev":
"606424bd7f6b579fdc99e1d230911b68147ecb31"}

[commit-bot: I haz the power, 2017-05-16 17:08:41]

Description was changed from

==========
Regsiter Ash prefs in mash

In classic ash, Chrome will invoke registering Ash prefs to the
asctive user's pref service, but in mash, Ash (as a pref service
client) must do that itself before connecting to the pref service.

BUG=721751
==========

to

==========
Regsiter Ash prefs in mash

In classic ash, Chrome will invoke registering Ash prefs to the
asctive user's pref service, but in mash, Ash (as a pref service
client) must do that itself before connecting to the pref service.

BUG=721751

Review-Url: https://codereview.chromium.org/2879243003
Cr-Commit-Position: refs/heads/master@{#472137}
Committed:
https://chromium.googlesource.com/chromium/src/+/606424bd7f6b579fdc99e1d23091...
==========

[commit-bot: I haz the power, 2017-05-16 17:08:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/606424bd7f6b579fdc99e1d23091...