Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2879233002: [css-typed-om] Replace cssText with stringifier at CSSTransformComponent (Closed)

Created:
3 years, 7 months ago by Hwanseung Lee
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-typed-om] Replace cssText with stringifier at CSSTransformComponent replace Replace cssText with stringifier at CSSTransformComponent. https://drafts.css-houdini.org/css-typed-om-1/#csstransformcomponent https://github.com/w3c/css-houdini-drafts/issues/364 BUG=545318 Review-Url: https://codereview.chromium.org/2879233002 Cr-Commit-Position: refs/heads/master@{#472035} Committed: https://chromium.googlesource.com/chromium/src/+/4d114d73277af70e55476abc5bf56a6d53c5b2bc

Patch Set 1 #

Patch Set 2 : [css-typed-om] replace cssText with toString at CSSTransformComponent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssMatrixComponent.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssPerspective.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssRotation.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssScale.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssSkew.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-perspective.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/typedcssom/inlinestyle/transform-scale.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/cssom/CSSTransformComponent.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (18 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 7 months ago (2017-05-16 00:14:49 UTC) #16
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:15:47 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879233002/60001
3 years, 7 months ago (2017-05-16 07:21:39 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 07:26:55 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/4d114d73277af70e55476abc5bf5...

Powered by Google App Engine
This is Rietveld 408576698