Chromium Code Reviews

Issue 2879223002: Don't try to set the empty string as the preferred set. (Closed)

Created:
3 years, 7 months ago by rune
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't try to set the empty string as the preferred set. Noticed during debugging that we did an extra MarkDocumentDirty() for active stylesheet update trying to change the preferred set from empty string to empty string in a document where no sheets had a title attribute. Guard the call sites which didn't check for emptiness and add a DCHECK in the SetPreferredStylesheetSetNameIfNotSet implementation. Review-Url: https://codereview.chromium.org/2879223002 Cr-Commit-Position: refs/heads/master@{#472039} Committed: https://chromium.googlesource.com/chromium/src/+/55085162c036ab80c4392d24cca15c28d7456848

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+25 lines, -3 lines)
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 3 chunks +8 lines, -3 lines 0 comments
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +17 lines, -0 lines 0 comments

Messages

Total messages: 12 (8 generated)
rune
ptal
3 years, 7 months ago (2017-05-15 14:23:11 UTC) #6
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-16 07:09:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879223002/1
3 years, 7 months ago (2017-05-16 08:02:15 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-16 08:06:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55085162c036ab80c4392d24cca1...

Powered by Google App Engine