Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 2879153002: Unskip previously failing tests (Closed)

Created:
3 years, 7 months ago by Michael Achenbach
Modified:
3 years, 7 months ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Unskip previously failing tests The test failures were caused by the impact of: http://crbug.com/723721 BUG=720511 Review-Url: https://codereview.chromium.org/2879153002 Cr-Commit-Position: refs/heads/master@{#472772} Committed: https://chromium.googlesource.com/chromium/src/+/c7a7012ae4f5ea85d17fd9ba9fb0892e080e877c

Patch Set 1 #

Patch Set 2 : Bisect 4184757eab3cd7fd4ff3e4b565f325e096bbf97b #

Patch Set 3 : Back to ToT #

Patch Set 4 : Rebase #

Patch Set 5 : keep failing tests skipped #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Michael Achenbach
PTAL
3 years, 7 months ago (2017-05-18 09:31:03 UTC) #5
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-18 11:07:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879153002/80001
3 years, 7 months ago (2017-05-18 11:57:34 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 12:03:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c7a7012ae4f5ea85d17fd9ba9fb0...

Powered by Google App Engine
This is Rietveld 408576698