Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.cpp

Issue 2879123002: Add generated InheritedDataShared in ComputedStyleBase. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/style/ComputedStyle.cpp
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.cpp b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
index e0a937b1a8a79675d239d6cba979d9b102231b60..8481abe7d32b5698d1e82738094ec3a2993e13da 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.cpp
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.cpp
@@ -475,8 +475,7 @@ bool ComputedStyle::NonInheritedEqual(const ComputedStyle& other) const {
bool ComputedStyle::InheritedDataShared(const ComputedStyle& other) const {
// This is a fast check that only looks if the data structures are shared.
- // TODO(sashab): Should ComputedStyleBase have an inheritedDataShared method?
- return ComputedStyleBase::InheritedEqual(other) &&
+ return ComputedStyleBase::InheritedDataShared(other) &&
inherited_data_.Get() == other.inherited_data_.Get() &&
svg_style_.Get() == other.svg_style_.Get() &&
rare_inherited_data_.Get() == other.rare_inherited_data_.Get();
« no previous file with comments | « third_party/WebKit/Source/build/scripts/templates/fields/field.tmpl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698