Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 2879103003: android: move ResourcePrefetchPredictor usage to LoadingPredictor. (Closed)

Created:
3 years, 7 months ago by Benoit L
Modified:
3 years, 7 months ago
CC:
chromium-reviews, lizeb+watch-custom-tabs_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: move ResourcePrefetchPredictor usage to LoadingPredictor. Following the native side refactoring (crrev.com/2847183002), update the android code entry points to LoadingPredictor. BUG=715525 Review-Url: https://codereview.chromium.org/2879103003 Cr-Commit-Position: refs/heads/master@{#471776} Committed: https://chromium.googlesource.com/chromium/src/+/cfe486d5448e3b37f38c7f854c0f284cff8850fa

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -183 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java View 4 chunks +4 lines, -4 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java View 1 1 chunk +66 lines, -0 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/customtabs/ResourcePrefetchPredictor.java View 1 chunk +0 lines, -67 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 2 4 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/predictors/loading_predictor.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/predictors/loading_predictor.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/predictors/loading_predictor_android.h View 1 chunk +16 lines, -0 lines 0 comments Download
A + chrome/browser/predictors/loading_predictor_android.cc View 5 chunks +13 lines, -13 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_android.h View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/predictors/resource_prefetch_predictor_android.cc View 1 chunk +0 lines, -73 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Benoit L
3 years, 7 months ago (2017-05-15 12:28:55 UTC) #4
alexilin
lgtm, thanks! https://codereview.chromium.org/2879103003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java File chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java (right): https://codereview.chromium.org/2879103003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java#newcode41 chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java:41: * @param url The URL to start ...
3 years, 7 months ago (2017-05-15 13:05:51 UTC) #5
Benoit L
Thanks! +bauerb: for chrome_jni_registrar.cc, only a rename and a bit of sorting. PTAL. https://codereview.chromium.org/2879103003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/customtabs/LoadingPredictor.java File ...
3 years, 7 months ago (2017-05-15 13:33:23 UTC) #6
Benoit L
Actually +bauerb!
3 years, 7 months ago (2017-05-15 15:17:52 UTC) #12
Bernhard Bauer
I like sorting! :) LGTM.
3 years, 7 months ago (2017-05-15 15:29:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2879103003/40001
3 years, 7 months ago (2017-05-15 15:40:41 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:53:59 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cfe486d5448e3b37f38c7f854c0f...

Powered by Google App Engine
This is Rietveld 408576698