third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h - Issue 2879093002: [LayoutNG] Fix ShapingLineBreaker when the end of range is needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h

Issue 2879093002: [LayoutNG] Fix ShapingLineBreaker when the end of range is needed (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.cpp » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h b/third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h

index 18938cb7c3377f2a067261ac7a09611381f806d6..75fecc1565993f54600cc8bbb06fd791a7e9b2df 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h

@@ -45,6 +45,9 @@ class PLATFORM_EXPORT ShapingLineBreaker final {

unsigned* break_offset);

private:

+ PassRefPtr<ShapeResult> ShapeToEnd(unsigned start,

+ LayoutUnit start_position,

+ unsigned range_end);

const HarfBuzzShaper* shaper_;

const Font* font_;