third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc - Issue 2879093002: [LayoutNG] Fix ShapingLineBreaker when the end of range is needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

Issue 2879093002: [LayoutNG] Fix ShapingLineBreaker when the end of range is needed (Closed)

Patch Set: Rebase Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker.cc ('k') | third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.h » ('j') | third_party/WebKit/Source/platform/fonts/shaping/ShapingLineBreaker.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

index 9b117e1e7e6d3280170d0967249b694ae7d1c663..cd39ff4dff3d66a0ea0b526024a2e312d0c1426d 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_breaker_test.cc

@@ -187,6 +187,26 @@ TEST_F(NGLineBreakerTest, OverflowMargin) {

EXPECT_EQ("789", ToString(lines[2], node));

}

+// Tests when the last word in a node wraps, and another node continues.

+TEST_F(NGLineBreakerTest, WrapLastWord) {

+ LoadAhem();

+ NGInlineNode node = CreateInlineNode(R"HTML(

+ <!DOCTYPE html>

+ <style>

+ #container {

+ font: 10px/1 Ahem;

+ }

+ </style>

+ <div id=container>AAA AAA AAA <span>BB</span> CC</div>

+ )HTML");

+ Vector<NGInlineItemResults> lines;

+ lines = BreakLines(node, LayoutUnit(100));

+ EXPECT_EQ(2u, lines.size());

+ EXPECT_EQ("AAA AAA", ToString(lines[0], node));

+ EXPECT_EQ("AAA BB CC", ToString(lines[1], node));

TEST_F(NGLineBreakerTest, BoundaryInWord) {

LoadAhem();

NGInlineNode node = CreateInlineNode(R"HTML(