Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: components/offline_pages/core/prefetch/prefetch_service.h

Issue 2879013002: Create skeleton for the Prefetching store and initial pipeline step. (Closed)
Patch Set: Dispatcher instance is now injected into Service. Minor changes. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/prefetch/prefetch_service.h
diff --git a/components/offline_pages/core/prefetch/prefetch_service.h b/components/offline_pages/core/prefetch/prefetch_service.h
index 9e5ec6cbf624796bcf6e14499e9a367ded03c657..24a9f830525720ccdffe3f44cdc7f1bfed5578ce 100644
--- a/components/offline_pages/core/prefetch/prefetch_service.h
+++ b/components/offline_pages/core/prefetch/prefetch_service.h
@@ -8,8 +8,8 @@
#include "components/keyed_service/core/keyed_service.h"
namespace offline_pages {
-
class PrefetchDispatcher;
+class PrefetchStore;
// Main class and entry point for the Offline Pages Prefetching feature, that
// controls the lifetime of all major subcomponents of the prefetching system.
@@ -18,6 +18,7 @@ class PrefetchService : public KeyedService {
~PrefetchService() override = default;
virtual PrefetchDispatcher* GetDispatcher() = 0;
fgorski 2017/05/30 17:21:45 Why are these public? How do you intend to use the
carlosk 2017/06/01 01:49:59 The service is supposed to be the ownership holder
+ virtual PrefetchStore* GetStore() = 0;
Dmitry Titov 2017/05/26 23:05:06 I think it would be more consistent to either have
carlosk 2017/06/01 01:49:59 Done.
};
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698