components/offline_pages/core/prefetch/prefetch_service.h - Issue 2879013002: Create skeleton for the Prefetching store and initial pipeline step.

Side by Side Diff: components/offline_pages/core/prefetch/prefetch_service.h

Issue 2879013002: Create skeleton for the Prefetching store and initial pipeline step. (Closed)

Patch Set: Dispatcher instance is now injected into Service. Minor changes. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« components/offline_pages/core/prefetch/prefetch_dispatcher_impl.cc ('K') | « components/offline_pages/core/prefetch/prefetch_dispatcher_impl_unittest.cc ('k') | components/offline_pages/core/prefetch/prefetch_service_impl.h » ('j') | components/offline_pages/core/prefetch/prefetch_service_impl.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_	5 #ifndef COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_

6 #define COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_	6 #define COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_

7	7

8 #include "components/keyed_service/core/keyed_service.h"	8 #include "components/keyed_service/core/keyed_service.h"

9	9

10 namespace offline_pages {	10 namespace offline_pages {

11

12 class PrefetchDispatcher;	11 class PrefetchDispatcher;

	12 class PrefetchStore;

13	13

14 // Main class and entry point for the Offline Pages Prefetching feature, that	14 // Main class and entry point for the Offline Pages Prefetching feature, that

15 // controls the lifetime of all major subcomponents of the prefetching system.	15 // controls the lifetime of all major subcomponents of the prefetching system.

16 class PrefetchService : public KeyedService {	16 class PrefetchService : public KeyedService {

17 public:	17 public:

18 ~PrefetchService() override = default;	18 ~PrefetchService() override = default;

19	19

20 virtual PrefetchDispatcher* GetDispatcher() = 0;	20 virtual PrefetchDispatcher* GetDispatcher() = 0;
	fgorski 2017/05/30 17:21:45 Why are these public? How do you intend to use the Why are these public? How do you intend to use the service? carlosk 2017/06/01 01:49:59 The service is supposed to be the ownership holder Show quoted text On 2017/05/30 17:21:45, fgorski wrote: > Why are these public? > How do you intend to use the service? The service is supposed to be the ownership holder of all prefetching sub-components, hence this getter. But I see where your doubt comes from and how this could be influenced by the design of the store.
	21 virtual PrefetchStore* GetStore() = 0;
	Dmitry Titov 2017/05/26 23:05:06 I think it would be more consistent to either have I think it would be more consistent to either have virtual Store* GetStore(); // this likely needs a new namespace or virtual PrefetchStore* GetPrefetchStore() same for GetDispatcher above... carlosk 2017/06/01 01:49:59 Done. Show quoted text On 2017/05/26 23:05:06, Dmitry Titov wrote: > I think it would be more consistent to either have > > virtual Store* GetStore(); // this likely needs a new namespace > or > virtual PrefetchStore* GetPrefetchStore() > > same for GetDispatcher above... Done.
21 };	22 };

22	23

23 } // namespace offline_pages	24 } // namespace offline_pages

24	25

25 #endif // COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_	26 #endif // COMPONENTS_OFFLINE_PAGES_CORE_PREFETCH_PREFETCH_SERVICE_H_

OLD	NEW