Remove some configuration from the extension URLRequestContexts.

Remove some configuration from the extension URLRequestContexts.

These are only used to access their cookie stores, so configuring them
so they can make network requests serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none

Review-Url: https://codereview.chromium.org/2878973002
Cr-Commit-Position: refs/heads/master@{#472342}
Committed: https://chromium.googlesource.com/chromium/src/+/51415ce87a4ef4fa2351f33278044a57d2bb6bd3

[mmenke, 2017-05-12 20:32:56]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:33:53]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-12 20:45:36]

Description was changed from

==========
Remove some configuration from the the extensions URLRequestContexts.

These are only used to access their cookie stores, so additional
configuration serves no purpose.

BUG=none
==========

to

==========
Remove some configuration from the the extension URLRequestContexts.

These are only used to access their cookie stores, so additional
configuration serves no purpose.

BUG=none
==========

[mmenke, 2017-05-12 20:46:27]

Description was changed from

==========
Remove some configuration from the the extension URLRequestContexts.

These are only used to access their cookie stores, so additional
configuration serves no purpose.

BUG=none
==========

to

==========
Remove some configuration from the the extension URLRequestContexts.

These are only used to access their cookie stores, so additional
configuration serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none
==========

[mmenke, 2017-05-12 20:48:16]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 20:48:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 21:34:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 21:34:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-05-15 15:07:35]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[mmenke, 2017-05-15 15:08:03]

Description was changed from

==========
Remove some configuration from the the extension URLRequestContexts.

These are only used to access their cookie stores, so additional
configuration serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none
==========

to

==========
Remove some configuration from the extension URLRequestContexts.

These are only used to access their cookie stores, so configuring them
so they can make network requests serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none
==========

[commit-bot: I haz the power, 2017-05-15 15:08:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-15 16:52:51]

mmenke@chromium.org changed reviewers:
+ rdsmith@chromium.org

[mmenke, 2017-05-15 16:52:51]

Randy:  This doesn't really have anything to do with my other CLs, just wanted
to do something late Friday, and was reluctant to make the CL dependency chain
longer until I'd started landing CLs.

This may make your cookie work marginally easier, or it may not.  This stuff was
probably just hooked up because people didn't realize the extensions context
wasn't made to use requests, as that wasn't all that clear from the code.

[mmenke, 2017-05-15 16:54:05]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 16:54:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 18:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 18:00:35]

Dry run: This issue passed the CQ dry run.

[Randy Smith (Not in Mondays), 2017-05-16 22:56:37]

Heh.  LGTM, though I'm slightly bothered by the implication (which I think is
true) that we do no net logging in cookie processing.

I think the cleanest way to represent this would be by having there be an
extensions cookie store rather than an extensions request context.  I'll keep
that in mind for possible future transformation on the cookies servicification
path.

[mmenke, 2017-05-16 23:41:40]

On 2017/05/16 22:56:37, Randy Smith (Not in Mondays) wrote:
> Heh.  LGTM, though I'm slightly bothered by the implication (which I think is
> true) that we do no net logging in cookie processing.

Note that most things either have their own pointer to the NetLog, or are passed
it on a per-request basis (i.e., things generally don't, and shouldn't, depend
on the URLRequestContext - that makes shutdown cleaner, too).  In this case,
though, I don't think the cookie store does any of those, though it could.

> I think the cleanest way to represent this would be by having there be an
> extensions cookie store rather than an extensions request context.  I'll keep
> that in mind for possible future transformation on the cookies servicification
> path.

[mmenke, 2017-05-16 23:41:42]

On 2017/05/16 22:56:37, Randy Smith (Not in Mondays) wrote:
> Heh.  LGTM, though I'm slightly bothered by the implication (which I think is
> true) that we do no net logging in cookie processing.

Note that most things either have their own pointer to the NetLog, or are passed
it on a per-request basis (i.e., things generally don't, and shouldn't, depend
on the URLRequestContext - that makes shutdown cleaner, too).  In this case,
though, I don't think the cookie store does any of those, though it could.

> I think the cleanest way to represent this would be by having there be an
> extensions cookie store rather than an extensions request context.  I'll keep
> that in mind for possible future transformation on the cookies servicification
> path.

[mmenke, 2017-05-16 23:53:49]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-16 23:55:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 05:47:38]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494978829566950,
"parent_rev": "9e472e822debee5894442de2b77dfd46d0ae9547", "commit_rev":
"51415ce87a4ef4fa2351f33278044a57d2bb6bd3"}

[commit-bot: I haz the power, 2017-05-17 05:47:52]

Description was changed from

==========
Remove some configuration from the extension URLRequestContexts.

These are only used to access their cookie stores, so configuring them
so they can make network requests serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none
==========

to

==========
Remove some configuration from the extension URLRequestContexts.

These are only used to access their cookie stores, so configuring them
so they can make network requests serves no purpose.

Also no longer hook them up to net-internals/net-export, since they
have no requests (This is also needed since after this CL, the code
no longer sets their NetLog)

BUG=none

Review-Url: https://codereview.chromium.org/2878973002
Cr-Commit-Position: refs/heads/master@{#472342}
Committed:
https://chromium.googlesource.com/chromium/src/+/51415ce87a4ef4fa2351f3327804...
==========

[commit-bot: I haz the power, 2017-05-17 05:47:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/51415ce87a4ef4fa2351f3327804...