VR: Poll media access flags

VR: Poll media access flags

VrShell polls to get the latest state of media access flags.

BUG=

Review-Url: https://codereview.chromium.org/2878893003
Cr-Commit-Position: refs/heads/master@{#471507}
Committed: https://chromium.googlesource.com/chromium/src/+/565ef494326106f9cd8fe3309f1075df9026bd82

[asimjour1, 2017-05-12 20:52:59]

asimjour@chromium.org changed reviewers:
+ mthiesse@chromium.org, vollick@chromium.org

[asimjour1, 2017-05-12 20:53:25]

PTAL

[mthiesse, 2017-05-12 22:01:30]

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:65: float
poll_media_access_interval_ = 0.01f;
Use a constexpr TimeDelta

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:529:
base::Bind(&VrShell::PollMediaAccessFlag, weak_ptr_factory_.GetWeakPtr()),
In order to avoid accidentally starting two loops use a cancelable callback,
like vrshell vsync.

[asimjour1, 2017-05-12 22:31:48]

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:65: float
poll_media_access_interval_ = 0.01f;
On 2017/05/12 22:01:30, mthiesse wrote:
> Use a constexpr TimeDelta

Done.

https://codereview.chromium.org/2878893003/diff/60001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:529:
base::Bind(&VrShell::PollMediaAccessFlag, weak_ptr_factory_.GetWeakPtr()),
On 2017/05/12 22:01:30, mthiesse wrote:
> In order to avoid accidentally starting two loops use a cancelable callback,
> like vrshell vsync.

Done.

[mthiesse, 2017-05-12 22:43:59]

https://codereview.chromium.org/2878893003/diff/80001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2878893003/diff/80001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:530:
weak_ptr_factory_.GetWeakPtr()));
No need for weakptr, just cancel the callback in the destructor.

[asimjour1, 2017-05-12 22:57:04]

https://codereview.chromium.org/2878893003/diff/80001/chrome/browser/android/...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2878893003/diff/80001/chrome/browser/android/...
chrome/browser/android/vr_shell/vr_shell.cc:530:
weak_ptr_factory_.GetWeakPtr()));
On 2017/05/12 22:43:59, mthiesse wrote:
> No need for weakptr, just cancel the callback in the destructor.

Done.

[mthiesse, 2017-05-12 23:01:40]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-05-12 23:02:47]

lgtm

[commit-bot: I haz the power, 2017-05-12 23:03:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asimjour1, 2017-05-12 23:03:53]

The CQ bit was unchecked by asimjour@chromium.org

[asimjour1, 2017-05-12 23:03:53]

The CQ bit was checked by asimjour@chromium.org

[commit-bot: I haz the power, 2017-05-12 23:04:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-13 00:23:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1494630233781930,
"parent_rev": "204a990c6d1d1cb9a72f50fe1a0639b0c176351d", "commit_rev":
"565ef494326106f9cd8fe3309f1075df9026bd82"}

[commit-bot: I haz the power, 2017-05-13 00:23:22]

Description was changed from

==========
VR: Poll media access flags

VrShell polls to get the latest state of media access flags.

BUG=
==========

to

==========
VR: Poll media access flags

VrShell polls to get the latest state of media access flags.

BUG=

Review-Url: https://codereview.chromium.org/2878893003
Cr-Commit-Position: refs/heads/master@{#471507}
Committed:
https://chromium.googlesource.com/chromium/src/+/565ef494326106f9cd8fe3309f10...
==========

[commit-bot: I haz the power, 2017-05-13 00:23:23]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/565ef494326106f9cd8fe3309f10...