Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 2878893002: Clean up some NewTabPage.* histograms in histograms.xml (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up some NewTabPage.* histograms in histograms.xml - Take a bunch over from people who don't work on this anymore. - Mark some unused ones as obsolete. BUG=none Review-Url: https://codereview.chromium.org/2878893002 Cr-Commit-Position: refs/heads/master@{#471588} Committed: https://chromium.googlesource.com/chromium/src/+/c3445e93b940e12b2e2275e9a985880a58aaa4b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M tools/metrics/histograms/histograms.xml View 12 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Marc Treib
PTAL!
3 years, 7 months ago (2017-05-12 08:58:00 UTC) #2
rkaplow
lgtm
3 years, 7 months ago (2017-05-12 13:46:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878893002/1
3 years, 7 months ago (2017-05-12 13:49:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/292418)
3 years, 7 months ago (2017-05-12 15:52:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878893002/1
3 years, 7 months ago (2017-05-12 15:54:02 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/292532)
3 years, 7 months ago (2017-05-12 18:17:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878893002/1
3 years, 7 months ago (2017-05-13 10:49:17 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 16:49:59 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c3445e93b940e12b2e2275e9a985...

Powered by Google App Engine
This is Rietveld 408576698