Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878873003:
Use TaskScheduler instead of SequencedWorkerPool in ios_chrome_gcm_profile_service_factory.cc. (Closed)
|
Created:
3 years, 7 months ago by fdoray Modified:
3 years, 7 months ago Reviewers:
fgorski CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed) Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse TaskScheduler instead of SequencedWorkerPool in ios_chrome_gcm_profile_service_factory.cc.
SequencedWorkerPool is being deprecated in favor of TaskScheduler.
BUG=667892
R=fgorski@chromium.org
Review-Url: https://codereview.chromium.org/2878873003
Cr-Commit-Position: refs/heads/master@{#473469}
Committed: https://chromium.googlesource.com/chromium/src/+/2cae1f836baed3be61df4cf38d09a6c1647a7899
Patch Set 1 #Patch Set 2 : fix-test-error #Patch Set 3 : rebase #Messages
Total messages: 20 (15 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Please take a look. This CL was generated automatically. The base::MayBlock() trait was specified for all call sites and the base::TaskPriority::BACKGROUND trait was specified for all non-test call sites. That may not be appropriate for your use case. Please verify that appropriate traits were used https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks. - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the shutdown behavior is not set explicitly (no base::TaskShutdownBehavior)? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN. Note that the default shutdown behavior is BLOCK_SHUTDOWN in SequencedWorkerPool and SKIP_ON_SHUTDOWN in TaskScheduler. What if the task priority is not set explicitly (no base::TaskPriority)? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority).
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495379491239000,
"parent_rev": "e4d6d342c3442f90f86a10b4c6a4dc43648ff88e", "commit_rev":
"2cae1f836baed3be61df4cf38d09a6c1647a7899"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of SequencedWorkerPool in ios_chrome_gcm_profile_service_factory.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=fgorski@chromium.org ========== to ========== Use TaskScheduler instead of SequencedWorkerPool in ios_chrome_gcm_profile_service_factory.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 R=fgorski@chromium.org Review-Url: https://codereview.chromium.org/2878873003 Cr-Commit-Position: refs/heads/master@{#473469} Committed: https://chromium.googlesource.com/chromium/src/+/2cae1f836baed3be61df4cf38d09... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/2cae1f836baed3be61df4cf38d09... |
