Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2878853002: Make CSSVariableResolver's interface object based instead of static functions (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index b848b0bb8947e3f095e1340eae002d5abf230d2d..0564ed4f5a021ce82658417f3c0c5b65565ad7db 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -1760,7 +1760,7 @@ void StyleResolver::ApplyCustomProperties(StyleResolverState& state,
state.AnimationUpdate().ActiveInterpolationsForCustomTransitions());
}
// TODO(leviw): stop recalculating every time
- CSSVariableResolver::ResolveVariableDefinitions(state);
+ CSSVariableResolver(state).ResolveVariableDefinitions();
if (RuntimeEnabledFeatures::cssApplyAtRulesEnabled()) {
if (CacheCustomPropertiesForApplyAtRules(state,
@@ -1779,7 +1779,7 @@ void StyleResolver::ApplyCustomProperties(StyleResolverState& state,
state,
state.AnimationUpdate().ActiveInterpolationsForCustomTransitions());
}
- CSSVariableResolver::ResolveVariableDefinitions(state);
+ CSSVariableResolver(state).ResolveVariableDefinitions();
}
}
}
@@ -1887,7 +1887,7 @@ void StyleResolver::ApplyMatchedStandardProperties(
apply_inherited_only = false;
// Registered custom properties are computed after high priority properties.
- CSSVariableResolver::ComputeRegisteredVariables(state);
+ CSSVariableResolver(state).ComputeRegisteredVariables();
// Now do the normal priority UA properties.
ApplyMatchedProperties<kLowPropertyPriority, kCheckNeedsApplyPass>(
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698