third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 2878853002: Make CSSVariableResolver's interface object based instead of static functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 2878853002: Make CSSVariableResolver's interface object based instead of static functions (Closed)

Patch Set: rebased Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

index 54bcb994514113982ccaa633bf4890a301df9d28..32f29b8b1542fc06db14f8216431846cc4ed94f3 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -119,8 +119,8 @@ void StyleBuilder::ApplyProperty(CSSPropertyID id,

bool omit_animation_tainted =

CSSAnimations::IsAnimationAffectingProperty(id);

const CSSValue* resolved_value =

- CSSVariableResolver::ResolveVariableReferences(state, id, value,

- omit_animation_tainted);

+ CSSVariableResolver(state).ResolveVariableReferences(

+ id, value, omit_animation_tainted);

ApplyProperty(id, state, *resolved_value);

if (!state.Style()->HasVariableReferenceFromNonInheritedProperty() &&