Worklet: Move common code of addModule from Main/ThreadedWorklet to Worklet

third_party/WebKit/Source/core/loader/WorkletScriptLoader.h

Index: third_party/WebKit/Source/core/loader/WorkletScriptLoader.h
diff --git a/third_party/WebKit/Source/core/loader/WorkletScriptLoader.h b/third_party/WebKit/Source/core/loader/WorkletScriptLoader.h
index 633896f35b343536dc594786849fc9beedcb2d43..f2404f910d16cac691e503bbef56fa30c89d48c9 100644
--- a/third_party/WebKit/Source/core/loader/WorkletScriptLoader.h
+++ b/third_party/WebKit/Source/core/loader/WorkletScriptLoader.h
@@ -44,7 +44,7 @@ class WorkletScriptLoader final
 
   // Fetches an URL and loads it as a classic script. Synchronously calls
   // Client::notifyWorkletScriptLoadingFinished() if there is an error.
-  void FetchScript(const String& script_url);
+  void FetchScript(const KURL& module_url_record);

[kinuko, 2017/05/12 03:45:07]

Is the 'module url record' term from the spec?  Naively it feels less clear what
this actually fetches, and if the given parameter is the URL to fetch or not,
but maybe it's clear in worklet terminology?

[nhiroki, 2017/05/12 04:00:16]

Yes, it's from the spec:

  "To disambiguate from a valid URL string it can also be referred to as a URL
record."
  (URL spec: https://url.spec.whatwg.org/#concept-url)

  "4. Let moduleURLRecord be the result of parsing the moduleURL argument
relative to outsideSettings."
  (Worklet spec: https://drafts.css-houdini.org/worklets/#dom-worklet-addmodule)

I have no strong opinion on it, but module code owners seem to prefer to align
variable names with spec terms.

 
   // Cancels resource loading and synchronously calls
   // Client::notifyWorkletScriptLoadingFinished().