Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2878823002: Remove 'const' prefix from functions that return BorderValue by value. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, nainar
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'const' prefix from functions that return BorderValue by value. There are several functions that create a BorderValue and return it by value. However, the return type is 'const BorderValue' not 'BorderValue' which makes it confusing because the 'const' is extraneous. This patch removes the 'const' prefix. BUG=710938 Review-Url: https://codereview.chromium.org/2878823002 Cr-Commit-Position: refs/heads/master@{#471242} Committed: https://chromium.googlesource.com/chromium/src/+/2fd9b8f36a1752754039ee9b817cbc08d721daf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
shend
Hi Naina, PTAL
3 years, 7 months ago (2017-05-12 05:20:23 UTC) #6
nainar
lgtm
3 years, 7 months ago (2017-05-12 05:23:08 UTC) #7
nainar
Just needs a rs
3 years, 7 months ago (2017-05-12 05:23:20 UTC) #9
meade_UTC10
lgtm
3 years, 7 months ago (2017-05-12 05:24:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878823002/1
3 years, 7 months ago (2017-05-12 07:07:42 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 07:13:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fd9b8f36a1752754039ee9b817c...

Powered by Google App Engine
This is Rietveld 408576698