Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: components/safe_browsing/password_protection/password_protection_request.h

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing/password_protection/password_protection_request.h
diff --git a/components/safe_browsing/password_protection/password_protection_request.h b/components/safe_browsing/password_protection/password_protection_request.h
index 80193e234320c5c7deba0c60cf0cdbe54c2ab5dd..f03e421286f70248883f91f31d54231e97e2ad45 100644
--- a/components/safe_browsing/password_protection/password_protection_request.h
+++ b/components/safe_browsing/password_protection/password_protection_request.h
@@ -61,6 +61,7 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
PasswordProtectionRequest(const GURL& main_frame_url,
const GURL& password_form_action,
const GURL& password_form_frame_url,
+ const std::string& legitinate_domain,
Nathan Parker 2017/05/12 22:27:59 nit: spelling. legitimate_domain
Jialiu Lin 2017/05/13 00:24:12 Done.
LoginReputationClientRequest::TriggerType type,
PasswordProtectionService* pps,
int request_timeout_in_ms);
@@ -127,6 +128,9 @@ class PasswordProtectionRequest : public base::RefCountedThreadSafe<
// Frame url of the detected password form.
const GURL password_form_frame_url_;
+ // Legitimate domain on which a password is saved and gets reused.
+ const std::string legitimate_domain_;
Nathan Parker 2017/05/12 22:27:59 Could we call this "saved_domain" or "associated_d
Jialiu Lin 2017/05/13 00:24:12 Rename to "saved_domain". "legitimate_domain" is u
+
// If this request is for unfamiliar login page or for a password reuse event.
const LoginReputationClientRequest::TriggerType request_type_;

Powered by Google App Engine
This is Rietveld 408576698