Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: components/password_manager/core/browser/password_reuse_detection_manager.cc

Issue 2878813002: Trigger protected password entry request on password reuse event. (Closed)
Patch Set: nit Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_reuse_detection_manager.cc
diff --git a/components/password_manager/core/browser/password_reuse_detection_manager.cc b/components/password_manager/core/browser/password_reuse_detection_manager.cc
index a45670fdc70596ea3a31bb804212699bf6033582..061a20126d19c28de23437001eb84f2e970a62b8 100644
--- a/components/password_manager/core/browser/password_reuse_detection_manager.cc
+++ b/components/password_manager/core/browser/password_reuse_detection_manager.cc
@@ -69,6 +69,8 @@ void PasswordReuseDetectionManager::OnReuseFound(
safe_browsing::PasswordProtectionService* password_protection_service =
client_->GetPasswordProtectionService();
password_protection_service->RecordPasswordReuse(main_frame_url_);
+ password_protection_service->MaybeStartProtectedPasswordEntryRequest(
Nathan Parker 2017/05/12 22:27:59 Could the Record be called from within MaybeStart?
Jialiu Lin 2017/05/13 00:24:12 I was thinking about removing the RecordPasswordRe
+ main_frame_url_, legitimate_domain);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698