Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Issue 2878763002: [Payments] Better default selections on iOS (Closed)

Created:
3 years, 7 months ago by Mathieu
Modified:
3 years, 7 months ago
Reviewers:
Moe
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), jam, gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, marq+watch_chromium.org, darin-cc_chromium.org, mahmadi+paymentswatch_chromium.org, noyau+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

* Only select a shipping profile if there is a selected shipping option * Select the most complete profile, in order of frecency. BUG=721458 TEST=ios_chrome_unittests Review-Url: https://codereview.chromium.org/2878763002 Cr-Commit-Position: refs/heads/master@{#471328} Committed: https://chromium.googlesource.com/chromium/src/+/f14c1e33e651019be3557f43121aff4a445c00b2

Patch Set 1 #

Total comments: 2

Patch Set 2 : rename method #

Patch Set 3 : fix test #

Patch Set 4 : fix test, really #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -34 lines) Patch
M components/payments/content/payment_request_state.cc View 3 chunks +16 lines, -6 lines 0 comments Download
M ios/chrome/browser/payments/payment_request.h View 1 3 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 5 chunks +36 lines, -15 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 1 2 3 11 chunks +198 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_coordinator.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/payments/payment_request_view_controller_unittest.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Mathieu
Moe, PTAL!
3 years, 7 months ago (2017-05-11 18:59:43 UTC) #5
Moe
LGTM! Thanks Mathieu! https://codereview.chromium.org/2878763002/diff/1/ios/chrome/browser/payments/payment_request.mm File ios/chrome/browser/payments/payment_request.mm (right): https://codereview.chromium.org/2878763002/diff/1/ios/chrome/browser/payments/payment_request.mm#newcode43 ios/chrome/browser/payments/payment_request.mm:43: PopulateShippingOptionCache(); should we update the selected ...
3 years, 7 months ago (2017-05-12 13:22:06 UTC) #8
Mathieu
Thanks, renamed one method and will submit https://codereview.chromium.org/2878763002/diff/1/ios/chrome/browser/payments/payment_request.mm File ios/chrome/browser/payments/payment_request.mm (right): https://codereview.chromium.org/2878763002/diff/1/ios/chrome/browser/payments/payment_request.mm#newcode43 ios/chrome/browser/payments/payment_request.mm:43: PopulateShippingOptionCache(); On ...
3 years, 7 months ago (2017-05-12 13:57:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878763002/20001
3 years, 7 months ago (2017-05-12 13:58:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/98492)
3 years, 7 months ago (2017-05-12 14:06:49 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878763002/40001
3 years, 7 months ago (2017-05-12 14:19:12 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/98508)
3 years, 7 months ago (2017-05-12 14:27:42 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878763002/60001
3 years, 7 months ago (2017-05-12 14:35:52 UTC) #22
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:37:48 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f14c1e33e651019be3557f43121a...

Powered by Google App Engine
This is Rietveld 408576698