Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2878703002: Use TaskScheduler instead of SequencedWorkerPool in sequenced_task_runner_handle_unittest.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of SequencedWorkerPool in sequenced_task_runner_handle_unittest.cc. SequencedWorkerPool is being deprecated in favor of TaskScheduler. BUG=667892 Review-Url: https://codereview.chromium.org/2878703002 Cr-Commit-Position: refs/heads/master@{#471746} Committed: https://chromium.googlesource.com/chromium/src/+/eec9c47b685afb76aeb26234f0cb9c46ae0aa007

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : CR gab #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -44 lines) Patch
M base/threading/sequenced_task_runner_handle_unittest.cc View 1 2 3 chunks +18 lines, -44 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
fdoray
PTAL
3 years, 7 months ago (2017-05-11 19:17:02 UTC) #6
gab
lgtm w/ comments https://codereview.chromium.org/2878703002/diff/20001/base/threading/sequenced_task_runner_handle_unittest.cc File base/threading/sequenced_task_runner_handle_unittest.cc (right): https://codereview.chromium.org/2878703002/diff/20001/base/threading/sequenced_task_runner_handle_unittest.cc#newcode48 base/threading/sequenced_task_runner_handle_unittest.cc:48: static void VerifyNoSequencedTaskRunner(const Closure& callback) { ...
3 years, 7 months ago (2017-05-12 18:23:58 UTC) #7
fdoray
https://codereview.chromium.org/2878703002/diff/20001/base/threading/sequenced_task_runner_handle_unittest.cc File base/threading/sequenced_task_runner_handle_unittest.cc (right): https://codereview.chromium.org/2878703002/diff/20001/base/threading/sequenced_task_runner_handle_unittest.cc#newcode48 base/threading/sequenced_task_runner_handle_unittest.cc:48: static void VerifyNoSequencedTaskRunner(const Closure& callback) { On 2017/05/12 18:23:58, ...
3 years, 7 months ago (2017-05-15 13:20:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878703002/40001
3 years, 7 months ago (2017-05-15 13:20:32 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 13:35:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/eec9c47b685afb76aeb26234f0cb...

Powered by Google App Engine
This is Rietveld 408576698