Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2878683002: Upstream service worker header test to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker header test to WPT - Re-locate file for eventual submission to the Web Platform Tests project - Improve "clean up" logic to consistently remove iframe from document - Remove unnecessary `<script>` tags BUG=688116, 537127 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2878683002 Cr-Commit-Position: refs/heads/master@{#471338} Committed: https://chromium.googlesource.com/chromium/src/+/d7585f5b58e656fe5e0902294b1ab6af2bca11f3

Patch Set 1 #

Messages

Total messages: 11 (6 generated)
mike3
Hi Mek, I'm not sure if this one is really suitable for WPT. It seems ...
3 years, 7 months ago (2017-05-11 15:16:11 UTC) #1
mike3
Almost forgot, here's the diff: https://gist.github.com/jugglinmike/6bacb96355252f5c2cb2237e9d511190
3 years, 7 months ago (2017-05-11 15:17:35 UTC) #2
falken
looks fine. lgtm. Add 537127 to the BUG list too to aid code archaeologists.
3 years, 7 months ago (2017-05-12 05:08:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878683002/1
3 years, 7 months ago (2017-05-12 15:22:56 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 16:51:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d7585f5b58e656fe5e0902294b1a...

Powered by Google App Engine
This is Rietveld 408576698