Remove base::NonThreadSafe from //device/generic_sensor/

Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=341945
Review-Url: https://codereview.chromium.org/2878653002
Cr-Commit-Position: refs/heads/master@{#472001}
Committed: https://chromium.googlesource.com/chromium/src/+/1d1971a0a142a71f3cb66aa36198fbb9671c9910

[ke.he, 2017-05-11 10:20:35]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 10:21:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 11:12:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 11:12:27]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[ke.he, 2017-05-11 12:35:34]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 12:35:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 14:12:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 14:12:52]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-05-11 14:22:41]

ke.he@intel.com changed reviewers:
+ alexander.shalamov@intel.com

[ke.he, 2017-05-11 14:22:42]

Hi, Alexander, PTAL, thanks.

I'm working on the servicification of generic_sensor, trybots complains that
base::NonThreadSafe is deprecated, so I create this CL to remove them.

[ke.he, 2017-05-15 09:41:50]

Description was changed from

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=
==========

to

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=689384
==========

[ke.he, 2017-05-15 09:42:24]

friendly ping:)

[shalamov, 2017-05-15 10:08:00]

alexander.shalamov@intel.com changed reviewers:
+ mikhail.pozdnyakov@intel.com, reillyg@chromium.org

[shalamov, 2017-05-15 10:08:00]

I'm not sure how this CL is fixing anything related to Bug 689384. Also,
PlatformSensorProviderBase is base::NonThreadSafe and IMO, it is more verbose
contract than using macro THREAD_CHECKER(thread_checker_);

ke.he@ Was there a bug for deprecating base::NonThreadSafe?

Reilly, Mikhail could you please take a look?

[ke.he, 2017-05-15 10:48:30]

Description was changed from

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=689384
==========

to

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=341945
==========

[ke.he, 2017-05-15 10:51:20]

On 2017/05/15 10:08:00, shalamov wrote:
> I'm not sure how this CL is fixing anything related to Bug 689384. Also,
> PlatformSensorProviderBase is base::NonThreadSafe and IMO, it is more verbose
> contract than using macro THREAD_CHECKER(thread_checker_);
> 
> ke.he@ Was there a bug for deprecating base::NonThreadSafe?
> 
> Reilly, Mikhail could you please take a look?

It is for deprecating base::NonThreadSafe only. Sorry I used the wrong bug ID.
It is found during the servicification of generic_sensor which is still ongoing.
Thanks:)

[Reilly Grant (use Gerrit), 2017-05-15 15:23:36]

lgtm with nit

https://codereview.chromium.org/2878653002/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_provider_base.cc (right):

https://codereview.chromium.org/2878653002/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_provider_base.cc:23:
DETACH_FROM_THREAD(thread_checker_);
No need to add a DETACH_FROM_THREAD here.

[Alexander Shalamov, 2017-05-15 15:40:13]

On 2017/05/15 10:51:20, ke.he wrote:
> On 2017/05/15 10:08:00, shalamov wrote:
> > I'm not sure how this CL is fixing anything related to Bug 689384. Also,
> > PlatformSensorProviderBase is base::NonThreadSafe and IMO, it is more
verbose
> > contract than using macro THREAD_CHECKER(thread_checker_);
> > 
> > ke.he@ Was there a bug for deprecating base::NonThreadSafe?
> > 
> > Reilly, Mikhail could you please take a look?
> 
> It is for deprecating base::NonThreadSafe only. Sorry I used the wrong bug ID.
> It is found during the servicification of generic_sensor which is still
ongoing.
> Thanks:)

Ok, thanks for updating bug id, makes more sense now.

[ke.he, 2017-05-15 23:23:28]

The CQ bit was checked by ke.he@intel.com to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 23:24:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:09:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-16 03:09:14]

Dry run: This issue passed the CQ dry run.

[ke.he, 2017-05-16 03:09:22]

Thanks all!

https://codereview.chromium.org/2878653002/diff/20001/device/generic_sensor/p...
File device/generic_sensor/platform_sensor_provider_base.cc (right):

https://codereview.chromium.org/2878653002/diff/20001/device/generic_sensor/p...
device/generic_sensor/platform_sensor_provider_base.cc:23:
DETACH_FROM_THREAD(thread_checker_);
On 2017/05/15 15:23:35, Reilly Grant wrote:
> No need to add a DETACH_FROM_THREAD here.

Done.

[ke.he, 2017-05-16 03:09:31]

The CQ bit was checked by ke.he@intel.com

[ke.he, 2017-05-16 03:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2878653002/#ps40001
(title: "Remove base::NonThreadSafe from //device/generic_sensor/")

[commit-bot: I haz the power, 2017-05-16 03:09:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-16 03:14:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494904171744560,
"parent_rev": "4d60bb8e8f149732f85716124e05c349b360c333", "commit_rev":
"1d1971a0a142a71f3cb66aa36198fbb9671c9910"}

[commit-bot: I haz the power, 2017-05-16 03:14:39]

Description was changed from

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=341945
==========

to

==========
Remove base::NonThreadSafe from //device/generic_sensor/

Uses base::ThreadChecker instead.

BUG=341945

Review-Url: https://codereview.chromium.org/2878653002
Cr-Commit-Position: refs/heads/master@{#472001}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d1971a0a142a71f3cb66aa36198...
==========

[commit-bot: I haz the power, 2017-05-16 03:14:40]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/1d1971a0a142a71f3cb66aa36198...