INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur.

third_party/WebKit/Source/core/editing/FrameSelection.cpp

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index c22bf0d092870588e3f7196856a4a3fff12ee946..3370926dd392fab50f025e4bf4594baf81ff8b06 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -218,8 +218,14 @@ bool FrameSelection::SetSelectionDeprecated(
 
   const SelectionInDOMTree old_selection_in_dom_tree =
       selection_editor_->GetSelectionInDOMTree();
-  if (old_selection_in_dom_tree == new_selection)
+  if (old_selection_in_dom_tree == new_selection) {
+    // Notify to a focused text control. Even if DOM representation of text
+    // selection is not changed, selectionStart / selectionEnd IDL attributes
+    // can be changed.
+    NotifyLayoutObjectOfSelectionChange(

[yosin_UTC9, 2017/05/11 09:41:55]

Could you rename NotifyLayoutObjectOfSelectionChange() to
NotifySelectionChangeToTextControl() or another?
NotifySetSelectionToTextControl() is better?

Since NotifyLayoutObjectOfSelectionChange() notifies to text control instead of
layout object.

Also, at glance, this change is hard to understand because a comment and newly
added function call doesn't
match.

WDYT?


void FrameSelection::NotifyLayoutObjectOfSelectionChange(
    EUserTriggered user_triggered) {
  TextControlElement* text_control =
      EnclosingTextControl(GetSelectionInDOMTree().Base());
  if (!text_control)
    return;
  text_control->SelectionChanged(user_triggered == kUserTriggered);
}

[Xiaocheng, 2017/05/11 18:37:18]

+1 for renaming.

+        SelectionOptionsToUserTriggered(options));
     return false;
+  }
   selection_editor_->SetSelection(new_selection);
   ScheduleVisualUpdateForPaintInvalidationIfNeeded();