INPUT/TEXTAREA elements: Fix incorrect selectionStart/selectionEnd values after blur.

third_party/WebKit/Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 200 matching lines @@
   // TODO(yosin): We should move to call |TypingCommand::closeTyping()| to
   // |Editor| class.
   if (close_typing)
     TypingCommand::CloseTyping(frame_);
 
   if (should_clear_typing_style)
     frame_->GetEditor().ClearTypingStyle();
 
   const SelectionInDOMTree old_selection_in_dom_tree =
       selection_editor_->GetSelectionInDOMTree();
-  if (old_selection_in_dom_tree == new_selection)
+  if (old_selection_in_dom_tree == new_selection) {
+    // Notify to a focused text control. Even if DOM representation of text
+    // selection is not changed, selectionStart / selectionEnd IDL attributes
+    // can be changed.
+    NotifyLayoutObjectOfSelectionChange(

[yosin_UTC9, 2017/05/11 09:41:55]

Could you rename NotifyLayoutObjectOfSelectionChange() to
NotifySelectionChangeToTextControl() or another?
NotifySetSelectionToTextControl() is better?

Since NotifyLayoutObjectOfSelectionChange() notifies to text control instead of
layout object.

Also, at glance, this change is hard to understand because a comment and newly
added function call doesn't
match.

WDYT?


void FrameSelection::NotifyLayoutObjectOfSelectionChange(
    EUserTriggered user_triggered) {
  TextControlElement* text_control =
      EnclosingTextControl(GetSelectionInDOMTree().Base());
  if (!text_control)
    return;
  text_control->SelectionChanged(user_triggered == kUserTriggered);
}

[Xiaocheng, 2017/05/11 18:37:18]

+1 for renaming.

+        SelectionOptionsToUserTriggered(options));
     return false;
+  }
   selection_editor_->SetSelection(new_selection);
   ScheduleVisualUpdateForPaintInvalidationIfNeeded();
 
   const Document& current_document = GetDocument();
   // TODO(yosin): We should get rid of unsued |options| for
   // |Editor::respondToChangedSelection()|.
   // Note: Since, setting focus can modify DOM tree, we should use
   // |oldSelection| before setting focus
   frame_->GetEditor().RespondToChangedSelection(
       old_selection_in_dom_tree.ComputeStartPosition(), options);
@@ skipping 951 matching lines @@
 }
 
 void showTree(const blink::FrameSelection* sel) {
   if (sel)
     sel->ShowTreeForThis();
   else
     LOG(INFO) << "Cannot showTree for <null> FrameSelection.";
 }
 
 #endif