Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2878563002: Add MacRTL feature to flags (Closed)

Created:
3 years, 7 months ago by lgrey
Modified:
3 years, 7 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MacRTL feature to flags BUG=673362 Review-Url: https://codereview.chromium.org/2878563002 Cr-Commit-Position: refs/heads/master@{#471031} Committed: https://chromium.googlesource.com/chromium/src/+/c0b638e52812ff1e84b14919a608408d7bb98933

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
lgrey
PTAL :)
3 years, 7 months ago (2017-05-10 20:45:55 UTC) #2
Elly Fong-Jones
lgtm
3 years, 7 months ago (2017-05-10 20:50:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878563002/1
3 years, 7 months ago (2017-05-10 20:53:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/266105) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, ...
3 years, 7 months ago (2017-05-11 02:57:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878563002/1
3 years, 7 months ago (2017-05-11 16:33:23 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/434180)
3 years, 7 months ago (2017-05-11 16:44:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878563002/20001
3 years, 7 months ago (2017-05-11 18:12:30 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:10:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c0b638e52812ff1e84b14919a608...

Powered by Google App Engine
This is Rietveld 408576698