Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 2878553002: Reland "Simplify FrameLoader::Clear(), remove FrameLoader::check_timer" (Closed)

Created:
3 years, 7 months ago by Nate Chapin
Modified:
3 years, 7 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Simplify FrameLoader::Clear(), remove FrameLoader::check_timer" Clear() is full of strange, old logic. Several clauses are outright unnecessary, or have better-encapsulated homes. check_timer_ appears to have two uses, one of which is vestigial, the other of which can be better-situated to not require a timer. BUG= Review-Url: https://codereview.chromium.org/2878553002 Cr-Commit-Position: refs/heads/master@{#471526} Committed: https://chromium.googlesource.com/chromium/src/+/2e62c43c2024d820f36302576f89cec7dd46130c

Patch Set 1 #

Patch Set 2 : Reorder LocalFrame::Detach, assert !IsLoading() before FrameLoader::Detach #

Patch Set 3 : Don't call CheckCompleted in HTMLFrameOwnerElement #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 2 7 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
Nate Chapin
The only difference between this and https://chromium.googlesource.com/chromium/src/+/2081f48578f7d6ff49d468a76e471f2b90f78178 is that I dropped the CheckCompleted() call in ...
3 years, 7 months ago (2017-05-12 21:42:19 UTC) #11
dcheng
OK, I think I've mostly convinced myself that we will perform a load completion check ...
3 years, 7 months ago (2017-05-12 22:30:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2878553002/40001
3 years, 7 months ago (2017-05-12 23:09:41 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-13 01:19:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2e62c43c2024d820f36302576f89...

Powered by Google App Engine
This is Rietveld 408576698