Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2878543004:
[DevTools] Fix UI.EmptyWidget scrollbars (Closed)
|
Created:
3 years, 7 months ago by eostroukhov Modified:
3 years, 7 months ago CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[DevTools] Fix UI.EmptyWidget scrollbars
BUG=699524, 696889
Review-Url: https://codereview.chromium.org/2878543004
Cr-Commit-Position: refs/heads/master@{#474393}
Committed: https://chromium.googlesource.com/chromium/src/+/66112904ff5090216cde196b83f0d44b6ae42e0f
Patch Set 1 #
Total comments: 1
Patch Set 2 : [DevTools] Improve the UI.EmptyWidget scrolling #
Total comments: 1
Patch Set 3 : Switched to min-width instead of flex-shrink:0 #Patch Set 4 : Fixed failing test #
Total comments: 6
Patch Set 5 : [DevTools] Improve the UI.EmptyWidget scrolling #
Messages
Total messages: 45 (34 generated)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
eostroukhov@chromium.org changed reviewers: + caseq@chromium.org, dgozman@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2878543004/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/resources/appManifestView.css (right): https://codereview.chromium.org/2878543004/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/resources/appManifestView.css:7: overflow: overlay; This seems to be webkit-specific and deprecated. Can we do it without resorting to this? Also, how about other places that use .empty-view? Perhaps just nuke padding there?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== [DevTools] Show the scrollbar as it used to be. This makes the scrollbar look same as it was on the "expected" video - e.g. both scroll buttons are visible. BUG=699524 ========== to ========== [DevTools] Fix UI.EmptyWidget scrollbars BUG=699524,696889 ==========
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Please take a look. I fixed the EmptyWidget - it now has a pane that does proper scrolling.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Gentle ping.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Switched to min-width instead of flex-shrink:0
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I slightly adjusted styling to avoid header clipping. Padding on the sides was removed, min-width for the panel was set.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Fixed failing test
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2878543004/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js (right): https://codereview.chromium.org/2878543004/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:42: this._panel = this.element.createChild('div', 'empty-view'); panel is a bit overloaded. this._contentElement perhaps? https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js (right): https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:42: this._panel = this.element.createChild('div', 'empty-view'); nit: panel is a bit overloaded. _contentElement or _innerElement perhaps? https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:43: this.textElement = this._panel.createChild('h2'); Can we make it private? I don't think it's used outside. https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:51: return this._panel.createChild('p'); Shouldn't this be under textElement?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by eostroukhov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Fixed vertical alignment https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... File third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js (right): https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:42: this._panel = this.element.createChild('div', 'empty-view'); On 2017/05/20 00:49:05, caseq wrote: > nit: panel is a bit overloaded. _contentElement or _innerElement perhaps? Done. https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:43: this.textElement = this._panel.createChild('h2'); On 2017/05/20 00:49:05, caseq wrote: > Can we make it private? I don't think it's used outside. Done. https://codereview.chromium.org/2878543004/diff/60001/third_party/WebKit/Sour... third_party/WebKit/Source/devtools/front_end/ui/EmptyWidget.js:51: return this._panel.createChild('p'); On 2017/05/20 00:49:05, caseq wrote: > Shouldn't this be under textElement? I don't think so. textElement is a main text, that is wrapped in a header element. Paragraphs appended here serve more as a description text.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by eostroukhov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org Link to the patchset: https://codereview.chromium.org/2878543004/#ps80001 (title: "[DevTools] Improve the UI.EmptyWidget scrolling")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495649444027750,
"parent_rev": "cd131b3025061c950f9e406129d5703532f153be", "commit_rev":
"66112904ff5090216cde196b83f0d44b6ae42e0f"}
Message was sent while issue was closed.
Description was changed from ========== [DevTools] Fix UI.EmptyWidget scrollbars BUG=699524,696889 ========== to ========== [DevTools] Fix UI.EmptyWidget scrollbars BUG=699524,696889 Review-Url: https://codereview.chromium.org/2878543004 Cr-Commit-Position: refs/heads/master@{#474393} Committed: https://chromium.googlesource.com/chromium/src/+/66112904ff5090216cde196b83f0... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/66112904ff5090216cde196b83f0... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
