chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java - Issue 2878543003: Hook up Reader Mode InfoBar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)

Patch Set: add new read-time metric and clean up some state Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromeTablet.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

index 434c3ad6bad320d6c2a398eb9671db8a845999dd..4824784d808aa98fea548514e210fd8b471310d0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java

@@ -13,7 +13,6 @@ import org.chromium.chrome.browser.compositor.layouts.phone.SimpleAnimationLayou

import org.chromium.chrome.browser.compositor.overlays.SceneOverlay;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchManagementDelegate;

import org.chromium.chrome.browser.device.DeviceClassManager;

-import org.chromium.chrome.browser.dom_distiller.ReaderModeManagerDelegate;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.TabCreatorManager;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

@@ -56,13 +55,12 @@ public class LayoutManagerChromePhone extends LayoutManagerChrome {

public void init(TabModelSelector selector, TabCreatorManager creator,

TabContentManager content, ViewGroup androidContentContainer,

ContextualSearchManagementDelegate contextualSearchDelegate,

- ReaderModeManagerDelegate readerModeDelegate,

DynamicResourceLoader dynamicResourceLoader) {

// Initialize Layouts

mSimpleAnimationLayout.setTabModelSelector(selector, content);

super.init(selector, creator, content, androidContentContainer, contextualSearchDelegate,

- readerModeDelegate, dynamicResourceLoader);

+ dynamicResourceLoader);

}

@Override