chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java - Issue 2878543003: Hook up Reader Mode InfoBar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

Issue 2878543003: Hook up Reader Mode InfoBar (Closed)

Patch Set: add new read-time metric and clean up some state Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChromePhone.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

index 0555a641276810dbc5a0e62277519eaa18f6d482..b9eac7b1a526409002c6673df35cabff7f26b7f2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManagerChrome.java

@@ -20,7 +20,6 @@ import org.chromium.chrome.browser.compositor.overlays.SceneOverlay;

import org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutHelperManager;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchManagementDelegate;

import org.chromium.chrome.browser.device.DeviceClassManager;

-import org.chromium.chrome.browser.dom_distiller.ReaderModeManagerDelegate;

import org.chromium.chrome.browser.fullscreen.FullscreenManager;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.chrome.browser.tabmodel.EmptyTabModelObserver;

@@ -196,7 +195,6 @@ public class LayoutManagerChrome

public void init(TabModelSelector selector, TabCreatorManager creator,

TabContentManager content, ViewGroup androidContentContainer,

ContextualSearchManagementDelegate contextualSearchDelegate,

- ReaderModeManagerDelegate readerModeDelegate,

DynamicResourceLoader dynamicResourceLoader) {

// TODO: TitleCache should be a part of the ResourceManager.

mTitleCache = mHost.getTitleCache();

@@ -207,7 +205,7 @@ public class LayoutManagerChrome

if (mOverviewLayout != null) mOverviewLayout.setTabModelSelector(selector, content);

super.init(selector, creator, content, androidContentContainer, contextualSearchDelegate,

- readerModeDelegate, dynamicResourceLoader);

+ dynamicResourceLoader);

mTabModelSelectorObserver = new EmptyTabModelSelectorObserver() {

@Override