Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2878543003: Hook up Reader Mode InfoBar (Closed)
Patch Set: add new read-time metric and clean up some state Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java ('K') | « chrome/browser/ui/android/infobars/reader_mode_infobar.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 441ddd975759eec65eb5b4aac562b77333853c84..c166ed87c05ce98d84cce8cbaa9c29bdc4f2488d 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -13355,6 +13355,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="DomDistiller.BarCloseButtonUsage" enum="BooleanPanelWasOpen">
+ <obsolete>
+ UI rewrite to be an InfoBar makes this metric irrelevant as of 05/2017.
+ </obsolete>
<owner>mdjones@chromium.org</owner>
<summary>
Records if the close button was used before or after opening and viewing
@@ -13392,6 +13395,11 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="DomDistiller.InfoBarUsage" enum="BooleanUsage">
+ <owner>mdjones@chromium.org</owner>
+ <summary>Records if the infobar was used or closed.</summary>
+</histogram>
+
<histogram name="DomDistiller.LongArticleScoreNMF.Negative" units="score">
<owner>wychen@chromium.org</owner>
<summary>
@@ -13532,6 +13540,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</histogram>
<histogram name="DomDistiller.Time.SwipeToPaint" units="ms">
+ <obsolete>
+ UI rewrite to be an InfoBar makes this metric irrelevant as of 05/2017.
+ </obsolete>
<owner>wychen@chromium.org</owner>
<summary>
Records the time from a swipe-up gesture on ReaderModePanel to the first
@@ -13546,7 +13557,17 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="DomDistiller.Time.ViewingReaderModePage" units="ms">
+ <owner>mdjones@chromium.org</owner>
+ <summary>
+ Records the amount of time a user spent on a Reader Mode Page.
+ </summary>
+</histogram>
+
<histogram name="DomDistiller.Time.ViewingReaderModePanel" units="ms">
+ <obsolete>
+ UI rewrite to be an InfoBar makes this metric irrelevant as of 05/2017.
+ </obsolete>
<owner>mdjones@chromium.org</owner>
<summary>
Records the amount of time between the Reader Mode panel opening and it
« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTabInfo.java ('K') | « chrome/browser/ui/android/infobars/reader_mode_infobar.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698